Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754628AbbGQWQe (ORCPT ); Fri, 17 Jul 2015 18:16:34 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38090 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbGQWQc (ORCPT ); Fri, 17 Jul 2015 18:16:32 -0400 From: Matthias Brugger To: Daniel Kurtz Cc: Chaotian Jing , Ulf Hansson , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Eddie Huang , HenryC Chen Subject: Re: [PATCH] arm64: dts: mediatek: Add MT8173 MMC dts Date: Sat, 18 Jul 2015 00:16:26 +0200 Message-ID: <2095363.Eo4NFi8jHO@ubix> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1437046580-10809-1-git-send-email-chaotian.jing@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5070 Lines: 137 On Thursday, July 16, 2015 11:16:59 PM Daniel Kurtz wrote: > Hi Chaotian, > > On Thu, Jul 16, 2015 at 7:36 PM, Chaotian Jing > > wrote: > > From: Eddie Huang > > > > Add node mmc0 ~ mmc3 for mt8173.dtsi > > Add node mmc0, mmc1 for mt8173-evb.dts > > > > Signed-off-by: Chaotian Jing > > Signed-off-by: Eddie Huang > > --- > > Remove clk_null > > Base on 4.2-rc1, and > > https://github.com/mbgg/linux-mediatek/tree/v4.2-next/arm64 commit > > 16ea61fc arm64: dts: mt8173-evb: Add PMIC support> > > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 126 > > ++++++++++++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt8173.dtsi > > | 44 ++++++++++ > > 2 files changed, 170 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts index 986f25f..f76c99b > > 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > @@ -64,6 +64,132 @@ > > > > }; > > > > }; > > > > +&mmc0 { > > + status = "okay"; > > + pinctrl-names = "default", "state_uhs"; > > + pinctrl-0 = <&mmc0_pins_default>; > > + pinctrl-1 = <&mmc0_pins_uhs>; > > + bus-width = <8>; > > + max-frequency = <50000000>; > > + cap-mmc-highspeed; > > + vmmc-supply = <&mt6397_vemc_3v3_reg>; > > + vqmmc-supply = <&mt6397_vio18_reg>; > > + non-removable; > > +}; > > + > > +&mmc1 { > > + status = "okay"; > > + pinctrl-names = "default", "state_uhs"; > > + pinctrl-0 = <&mmc1_pins_default>; > > + pinctrl-1 = <&mmc1_pins_uhs>; > > + bus-width = <4>; > > + max-frequency = <50000000>; > > + cap-sd-highspeed; > > + sd-uhs-sdr25; > > + cd-gpios = <&pio 132 0>; > > + vmmc-supply = <&mt6397_vmch_reg>; > > + vqmmc-supply = <&mt6397_vmc_reg>; > > +}; > > + > > +&pio { > > + mmc0_pins_default: mmc0default { > > + pins_cmd_dat { > > + pinmux = > > , + > > , + > > , + > > , + > > , + > > , + > > , + > > , > > + > > ; + > > input-enable; > > + bias-pull-up; > > + }; > > + > > + pins_clk { > > + pinmux = > > ; > > + bias-pull-down; > > + }; > > + > > + pins_rst { > > + pinmux = > > ; + > > bias-pull-up; > > + }; > > + }; > > + > > + mmc1_pins_default: mmc1default { > > + pins_cmd_dat { > > + pinmux = > > , + > > , + > > , + > > , + > > ; + > > input-enable; > > + drive-strength = ; > > + bias-pull-up = ; > > + }; > > + > > + pins_clk { > > + pinmux = > > ; > > + bias-pull-down; > > + drive-strength = ; > > + }; > > + > > + pins_insert { > > + pinmux = > > ; > > + bias-pull-up; > > + }; > > + }; > > + > > + mmc0_pins_uhs: mmc0@0{ > > (1) I don't think these "@0" are needed (here and for mmc1_pins_uhs) > (2) A space before the '{' would be nice. > > Other than these tiny nits, this one is: > > Reviewed-by: Daniel Kurtz > I fixed the nits mentioned by Dan and applied the patch to v4.2-next/arm64 Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/