Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754867AbbGQWQu (ORCPT ); Fri, 17 Jul 2015 18:16:50 -0400 Received: from www.linutronix.de ([62.245.132.108]:49305 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbGQWQs (ORCPT ); Fri, 17 Jul 2015 18:16:48 -0400 Date: Sat, 18 Jul 2015 00:16:26 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Stephane Eranian , Andi Kleen , Peter Zijlstra , LKML Subject: Re: [PATCH 3/3] x86, perf: Add PEBS frontend profiling for Skylake In-Reply-To: <20150717203315.GI7380@tassilo.jf.intel.com> Message-ID: References: <1435612935-24425-1-git-send-email-andi@firstfloor.org> <1435612935-24425-3-git-send-email-andi@firstfloor.org> <20150717200900.GE7380@tassilo.jf.intel.com> <20150717203315.GI7380@tassilo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 46 On Fri, 17 Jul 2015, Andi Kleen wrote: > On Fri, Jul 17, 2015 at 10:11:28PM +0200, Thomas Gleixner wrote: > > On Fri, 17 Jul 2015, Andi Kleen wrote: > > > > > > I believe this mask of 0x3fff17 is wrong and should instead be > > > > 0x7fffff based on the description of the FRONTEND > > > > MSR I see in the SDM Table 18-54 (bit 0-22 are valid). Otherwise, some > > > > valid latency values may be rejected. > > > > > > No, my mask is correct. > > > > Provide a proper argument for that. Just claiming 'my mask is correct' > > definitely falls not into that category. > > Because I actually tested the code unlike you or Stephane. You know fcking well that I cannot test on skylake and probably Stephane can't either. > # wrmsr 0x3f7 0x3fff17 > # wrmsr 0x3f7 0x7fffff > wrmsr: CPU 0 cannot set MSR 0x000003f7 to 0x00000000007fffff > # So you think that's an explanation? No, it is NOT. It's merily an observation on some particular piece of HW to which you have access to exclusively. Nobody asks you to reveal NDA information, but you should at least have the courtesy to provide an explanation which is understandable to others. The minimal explanation you could have provided would have been: "On my test machine the valid mask is 0x3fff17 contrary to the SDM which defines the valid mask as 0x7fffff" 'My mask is correct' is definitely not an explanation at all. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/