Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbbGRBXi (ORCPT ); Fri, 17 Jul 2015 21:23:38 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:34589 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753110AbbGRBXh (ORCPT ); Fri, 17 Jul 2015 21:23:37 -0400 MIME-Version: 1.0 In-Reply-To: <1437088996-28511-1-git-send-email-toshi.kani@hp.com> References: <1437088996-28511-1-git-send-email-toshi.kani@hp.com> Date: Fri, 17 Jul 2015 18:23:35 -0700 Message-ID: Subject: Re: [PATCH RESEND 0/3] mm, x86: Fix ioremap RAM check interfaces From: Dan Williams To: Toshi Kani Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , travis@sgi.com, roland@purestorage.com, Luis Rodriguez , X86 ML , "linux-kernel@vger.kernel.org" , Linux MM Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 37 On Thu, Jul 16, 2015 at 4:23 PM, Toshi Kani wrote: > ioremap() checks if a target range is in RAM and fails the request > if true. There are multiple issues in the iormap RAM check interfaces. > > 1. region_is_ram() always fails with -1. > 2. The check calls two functions, region_is_ram() and > walk_system_ram_range(), which are redundant as both walk the > same iomem_resource table. > 3. walk_system_ram_range() requires RAM ranges be page-aligned in > the iomem_resource table to work properly. This restriction > has allowed multiple ioremaps to RAM which are page-unaligned. > > This patchset solves issue 1 and 2. It does not address issue 3, > but continues to allow the existing ioremaps to work until it is > addressed. > > --- > resend: > - Rebased to 4.2-rc2 (no change needed). Modified change logs. > > --- > Toshi Kani (3): > 1/3 mm, x86: Fix warning in ioremap RAM check > 2/3 mm, x86: Remove region_is_ram() call from ioremap > 3/3 mm: Fix bugs in region_is_ram() > For the series... Reviewed-by: Dan Williams I'm going to base my ioremap + memremap series on top of these fixes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/