Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754564AbbGRD6Z (ORCPT ); Fri, 17 Jul 2015 23:58:25 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:33852 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbbGRD6Y (ORCPT ); Fri, 17 Jul 2015 23:58:24 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <86d54db50bda0aa4f4bbb09ed3a1e3d3> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55A9CD6A.806@rock-chips.com> Date: Sat, 18 Jul 2015 11:52:10 +0800 From: zhengxing User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-3-git-send-email-zhengxing@rock-chips.com> <20150717181122.GT11162@sirena.org.uk> In-Reply-To: <20150717181122.GT11162@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 16 Hi Mark, On 2015年07月18日 02:11, Mark Brown wrote: > On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: >> From: zhengxing >> >> The driver is used for rockchip board using a rt5645/rt5650. > Same comments here, mostly good but some minor issues. The other thing > with both of these is that you need to have a binding document for them. OK. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/