Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbbGRNq7 (ORCPT ); Sat, 18 Jul 2015 09:46:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43047 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbbGRNq5 (ORCPT ); Sat, 18 Jul 2015 09:46:57 -0400 Date: Sat, 18 Jul 2015 08:46:55 -0500 From: Josh Poimboeuf To: Borislav Petkov Cc: Andy Lutomirski , Ingo Molnar , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Andi Kleen , Pedro Alves , X86 ML , live-patching@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 13/21] x86/asm/crypto: Fix frame pointer usage in aesni-intel_asm.S Message-ID: <20150718134655.GB24587@treble.redhat.com> References: <20150717194307.GA26757@gmail.com> <20150717203746.GB12761@treble.redhat.com> <20150717204438.GC12761@treble.redhat.com> <20150717205930.GD12761@treble.redhat.com> <20150717211019.GE12761@treble.redhat.com> <20150718084236.GA26430@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150718084236.GA26430@nazgul.tnic> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 28 On Sat, Jul 18, 2015 at 10:42:36AM +0200, Borislav Petkov wrote: > On Fri, Jul 17, 2015 at 04:10:19PM -0500, Josh Poimboeuf wrote: > > Actually I'm not done painting. Personally it seems a little too > > verbose. I still like ENTRY_FRAME and ENDPROC_FRAME_RETURN :p > > Let's balance it out even more: > > ENTRY_FRAME(..) > > ... > > ENDPROC_FRAME(..) I like the balance, but the "ret" is still non-obvious. How about: FRAME_ENTRY(...) FRAME_RETURN(...) -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/