Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752308AbbGROXX (ORCPT ); Sat, 18 Jul 2015 10:23:23 -0400 Received: from mga14.intel.com ([192.55.52.115]:38378 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbbGROXV (ORCPT ); Sat, 18 Jul 2015 10:23:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,499,1432623600"; d="scan'208";a="526442223" Date: Sat, 18 Jul 2015 07:23:01 -0700 From: Andi Kleen To: Stephane Eranian Cc: Thomas Gleixner , Andi Kleen , Peter Zijlstra , LKML Subject: Re: [PATCH 3/3] x86, perf: Add PEBS frontend profiling for Skylake Message-ID: <20150718142301.GO7380@tassilo.jf.intel.com> References: <1435612935-24425-3-git-send-email-andi@firstfloor.org> <20150717200900.GE7380@tassilo.jf.intel.com> <20150717203315.GI7380@tassilo.jf.intel.com> <20150717211955.GK7380@tassilo.jf.intel.com> <20150717233100.GN7380@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 33 On Fri, Jul 17, 2015 at 04:52:56PM -0700, Stephane Eranian wrote: > On Fri, Jul 17, 2015 at 4:31 PM, Andi Kleen wrote: > > On Fri, Jul 17, 2015 at 03:00:18PM -0700, Stephane Eranian wrote: > >> Andi, > >> > >> On Fri, Jul 17, 2015 at 2:19 PM, Andi Kleen wrote: > >> >> But then, the SDM is misleading. It is not describing what's > >> >> implemented for SKL. > >> > > >> > Actually it has a list of valid values you can put into the various fields. > >> > None of them have the bits set you're trying to set. > >> > > >> You are talking about the events (bit 0-7). I am talking about the bubble > >> thresholds. I am okay with the event list for bits 0-7. > > > > Fair enough. There's a one-off in the MSR table and table 18-54. The IDQ > > bubble width is only 21:20. I'll ask for that to be fixed in both places > > that document them. > > > There is still something broken here, if bit 22 is not implemented, > then you have > a bunch of frontend events in the SKL event table (download.01.org) which are > bogus: I double checked and bit 22 is actually implemented. I'll send a patch to update the mask in the driver. Thanks for the report. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/