Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbbGRQAZ (ORCPT ); Sat, 18 Jul 2015 12:00:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbGRQAX (ORCPT ); Sat, 18 Jul 2015 12:00:23 -0400 Date: Sat, 18 Jul 2015 11:00:21 -0500 From: Josh Poimboeuf To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Andi Kleen , Pedro Alves , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/21] stackvalidate: Add C version of STACKVALIDATE_IGNORE_INSN Message-ID: <20150718160021.GC19968@treble.redhat.com> References: <3696c19542f8a29d66735b894d5414f6a9860c98.1437150175.git.jpoimboe@redhat.com> <20150718145654.GC30713@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150718145654.GC30713@nazgul.tnic> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 52 On Sat, Jul 18, 2015 at 04:56:54PM +0200, Borislav Petkov wrote: > On Fri, Jul 17, 2015 at 11:47:18AM -0500, Josh Poimboeuf wrote: > > Add a C inline asm string version of the STACKVALIDATE_IGNORE_INSN macro > > which tells stackvalidate to ignore the subsequent instruction. > > > > Signed-off-by: Josh Poimboeuf > > --- > > arch/x86/include/asm/stackvalidate.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/x86/include/asm/stackvalidate.h b/arch/x86/include/asm/stackvalidate.h > > index 2d23c23..dac935c 100644 > > --- a/arch/x86/include/asm/stackvalidate.h > > +++ b/arch/x86/include/asm/stackvalidate.h > > @@ -23,6 +23,15 @@ > > .endif > > .endm > > > > +#else /* !__ASSEMBLY__ */ > > + > > #ifdef CONFIG_STACK_VALIDATION > > > +#define STACKVALIDATE_IGNORE_INSN \ > > + ".Ltemp" __stringify(__LINE__) ":;" \ > > + ".pushsection __stackvalidate_ignore_insn, \"a\";" \ > > + _ASM_ALIGN ";" \ > > + ".long .Ltemp" __stringify(__LINE__) " - .;" \ > > + ".popsection;" > > + > > #endif > > > Also, you should end your lines with "\n" so that the .s output looks > a bit more readable, not like now: > > #APP > # 30 "./arch/x86/include/asm/arch_hweight.h" 1 > 661: > .Ltemp32:;.pushsection __stackvalidate_ignore_insn, "a"; .balign 8 ;.long .Ltemp32 - .;.popsection;call __sw_hweight32 > 662: Ok, will fix both issues. Thanks. -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/