Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbbGSLKo (ORCPT ); Sun, 19 Jul 2015 07:10:44 -0400 Received: from mta-out1.inet.fi ([62.71.2.230]:50454 "EHLO johanna2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbbGSLKm (ORCPT ); Sun, 19 Jul 2015 07:10:42 -0400 RazorGate-KAS: Rate: 5 RazorGate-KAS: {RECEIVED: dynamic ip detected} RazorGate-KAS: Envelope from: RazorGate-KAS: Version: 5.5.3 RazorGate-KAS: LuaCore: 80 2014-11-10_18-01-23 260f8afb9361da3c7edfd3a8e3a4ca908191ad29 RazorGate-KAS: Method: none RazorGate-KAS: Lua profiles 69136 [Nov 12 2014] RazorGate-KAS: Status: not_detected Date: Sun, 19 Jul 2015 14:10:19 +0300 From: "Kirill A. Shutemov" To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , Naoya Horiguchi , Mark Williamson , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v4 3/5] pagemap: rework hugetlb and thp report Message-ID: <20150719111019.GA2392@node.dhcp.inet.fi> References: <20150714152516.29844.69929.stgit@buzz> <20150714153738.29844.39039.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150714153738.29844.39039.stgit@buzz> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 19 On Tue, Jul 14, 2015 at 06:37:39PM +0300, Konstantin Khlebnikov wrote: > @@ -1073,35 +1047,48 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > pte_t *pte, *orig_pte; > int err = 0; > > - if (pmd_trans_huge_lock(pmd, vma, &ptl) == 1) { > - u64 flags = 0; > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > + if (pmd_trans_huge_lock(pmdp, vma, &ptl) == 1) { #ifdef is redundant. pmd_trans_huge_lock() always return 0 for !THP. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/