Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbbGSMZl (ORCPT ); Sun, 19 Jul 2015 08:25:41 -0400 Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:52870 "EHLO mx0a-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbbGSMZj convert rfc822-to-8bit (ORCPT ); Sun, 19 Jul 2015 08:25:39 -0400 From: Yuval Mintz To: nick , Ariel Elior CC: netdev , linux-kernel Subject: RE: [PATCH 1/2] bnx2x:Fix error handling in the function bnxc2x_dbcx_set_params Thread-Topic: [PATCH 1/2] bnx2x:Fix error handling in the function bnxc2x_dbcx_set_params Thread-Index: AQHQwVv9DekzVKBfL0ucjaIOb0NoxJ3iWwUAgADSroD//4sMAA== Date: Sun, 19 Jul 2015 12:25:36 +0000 Message-ID: References: <1437225397-26079-1-git-send-email-xerofoify@gmail.com> <55AB9673.7060704@gmail.com> In-Reply-To: <55AB9673.7060704@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7866 signatures=670607 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507190196 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 24 > I am used to sending out one patch per each fix like this for each function. > If you don't like me doing this I don't when sending patches for your > subsystem(s). I think that would be preferable. > In addition would something like this fix your complains about not fixing error > handling in bnx2x_dcbnl_update_applist. > int bnx2x_dcbnl_update_applist(struct bnx2x *bp, bool delall) { > int i, err = 0; > > for (i = 0; i < DCBX_MAX_APP_PROTOCOL && err == 0; i++) { ... > err = dcb_setapp(bp->dev, &app); > + if (err) > + break; Well, either that or retain the fact there's an error and return it at the end. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/