Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbbGSNA2 (ORCPT ); Sun, 19 Jul 2015 09:00:28 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47180 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbbGSNA0 (ORCPT ); Sun, 19 Jul 2015 09:00:26 -0400 Message-ID: <55AB9F68.7000201@kernel.org> Date: Sun, 19 Jul 2015 14:00:24 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Manfred Schlaegl , Michael Welling CC: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Manfred Schlaegl Subject: Re: [PATCH] iio: mcp320x: Fix NULL pointer dereference References: <55A03142.1020106@gmx.at> <20150713141607.GB3224@deathray> <55A4F848.8060507@gmx.at> In-Reply-To: <55A4F848.8060507@gmx.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 63 On 14/07/15 12:53, Manfred Schlaegl wrote: > On 2015-07-13 16:16, Michael Welling wrote: >> On Fri, Jul 10, 2015 at 10:55:30PM +0200, Manfred Schlaegl wrote: >>> On reading in_voltage_scale of we got an NULL pointer dereference Oops. >>> >>> The reason for this is, that mcp320x_read_raw tries to access >>> chip_info->resolution from struct mcp320x, but chip_info is never set. >>> >>> chip_info was never set since the driver was added, but there was no >>> acute problem, because it was not referenced. >>> The acute problem exists since >>> b12206e917ac34bec41b9ff93d37d8bd53a2b3bc >>> iio: adc: mcp320x. Add support for more ADCs >>> >>> This patch fixes the issue by setting chip_info in mcp320x_probe. >>> >>> Signed-off-by: Manfred Schlaegl >>> --- >>> drivers/iio/adc/mcp320x.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c >>> index 8d9c9b9..d819823 100644 >>> --- a/drivers/iio/adc/mcp320x.c >>> +++ b/drivers/iio/adc/mcp320x.c >>> @@ -299,6 +299,8 @@ static int mcp320x_probe(struct spi_device *spi) >>> indio_dev->channels = chip_info->channels; >>> indio_dev->num_channels = chip_info->num_channels; >>> >>> + adc->chip_info = chip_info; >>> + >> >> Looks good to me. >> >> Reviewed-by: Michael Welling >> >>> adc->transfer[0].tx_buf = &adc->tx_buf; >>> adc->transfer[0].len = sizeof(adc->tx_buf); >>> adc->transfer[1].rx_buf = adc->rx_buf; >>> -- >>> 1.7.10.4 >>> > > Thanks for reviewing! > > best regards, > manfred > Applied to the fixes-togreg branch of iio.git Michael, there are moves afoot to clarify the meaning of reviewed-by as covering only more substantial reviews (kind of tricky on a one liner like this!) Hence for similar patches in future, an Acked-by may be more appropriate. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/