Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbbGSODJ (ORCPT ); Sun, 19 Jul 2015 10:03:09 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47658 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbbGSODG (ORCPT ); Sun, 19 Jul 2015 10:03:06 -0400 Message-ID: <55ABAE18.4000308@kernel.org> Date: Sun, 19 Jul 2015 15:03:04 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Hartmut Knaack , Cristina Opriceana CC: lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.baluta@intel.com, octavian.purdila@intel.com Subject: Re: [PATCH 3/3] tools: iio: Add ARRAY_SIZE macro References: <55A4083C.6030107@gmx.de> In-Reply-To: <55A4083C.6030107@gmx.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 56 On 13/07/15 19:49, Hartmut Knaack wrote: > Cristina Opriceana schrieb am 13.07.2015 um 15:20: >> Calculation of the length of an array can be done with the ARRAY_SIZE >> macro to make code more abstract and remove the associated >> checkpatch.pl warning. >> >> Signed-off-by: Cristina Opriceana > Acked-by: Hartmut Knaack Applied to the togreg branch of iio.git and initially pushed out as testing. Good patch set, thanks! Jonathan >> --- >> tools/iio/iio_utils.c | 2 +- >> tools/iio/iio_utils.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c >> index 4a7e480..e177f40 100644 >> --- a/tools/iio/iio_utils.c >> +++ b/tools/iio/iio_utils.c >> @@ -39,7 +39,7 @@ int iioutils_break_up_name(const char *full_name, char **generic_name) >> char *working, *prefix = ""; >> int i, ret; >> >> - for (i = 0; i < sizeof(iio_direction) / sizeof(iio_direction[0]); i++) >> + for (i = 0; i < ARRAY_SIZE(iio_direction); i++) >> if (!strncmp(full_name, iio_direction[i], >> strlen(iio_direction[i]))) { >> prefix = iio_direction[i]; >> diff --git a/tools/iio/iio_utils.h b/tools/iio/iio_utils.h >> index 0866101..f30a109 100644 >> --- a/tools/iio/iio_utils.h >> +++ b/tools/iio/iio_utils.h >> @@ -18,6 +18,8 @@ >> #define FORMAT_SCAN_ELEMENTS_DIR "%s/scan_elements" >> #define FORMAT_TYPE_FILE "%s_type" >> >> +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) >> + >> extern const char *iio_dir; >> >> /** >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/