Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbbGSSlY (ORCPT ); Sun, 19 Jul 2015 14:41:24 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37732 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbbGSSlX (ORCPT ); Sun, 19 Jul 2015 14:41:23 -0400 Date: Sun, 19 Jul 2015 11:41:22 -0700 (PDT) Message-Id: <20150719.114122.199681184036898625.davem@davemloft.net> To: dvlasenk@redhat.com Cc: tgraf@suug.ch, tom@herbertland.com, alexander.h.duyck@redhat.com, kadlec@blackhole.kfki.hu, herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] jhash: Deinline jhash and jhash2 From: David Miller In-Reply-To: <1437320160-13290-1-git-send-email-dvlasenk@redhat.com> References: <1437320160-13290-1-git-send-email-dvlasenk@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 19 Jul 2015 11:41:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 30 From: Denys Vlasenko Date: Sun, 19 Jul 2015 17:36:00 +0200 > This patch deinlines jhash and jhash2. > > It also removes rhashtable_jhash2(key, length, seed) > because it was merely calling jhash2(key, length, seed). > > With this .config: http://busybox.net/~vda/kernel_config, > after deinlining these functions have sizes and callsite counts > as follows: > > jhash: 297 bytes, 111 calls > jhash2: 205 bytes, 136 calls > > Total size decrease is about 33,000 bytes: > > text data bss dec hex filename > 90663567 17221960 36659200 144544727 89d93d7 vmlinux5 > 90630370 17221864 36659200 144511434 89d11ca vmlinux.after > > Signed-off-by: Denys Vlasenko No performance metrics at all have been provided, so this should not be applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/