Date: Mon, 20 Jul 2015 09:23:09 +0800
From: Peter Chen <peter.chen@freescale.com>
To: Roger Quadros <rogerq@ti.com>
CC: Li Jun <b47624@freescale.com>, <stern@rowland.harvard.edu>, <balbi@ti.com>,
        <gregkh@linuxfoundation.org>, <dan.j.williams@intel.com>,
        <jun.li@freescale.com>, <mathias.nyman@linux.intel.com>,
        <tony@atomide.com>, <Joao.Pinto@synopsys.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support
Message-ID: <20150720012308.GB4584@shlinux2>
References: <1436350777-28056-1-git-send-email-rogerq@ti.com>
 <1436350777-28056-11-git-send-email-rogerq@ti.com>
 <20150717090212.GC4515@shlinux2> <55A8DD30.5030407@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <55A8DD30.5030407@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
CY1PR0301MB1228: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2015 02:32:37.4807
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1228
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1264
Lines: 47

On Fri, Jul 17, 2015 at 01:47:12PM +0300, Roger Quadros wrote:
> >> + * DRD mode hardware Inputs
> >> + *
> >> + * @id:		TRUE for B-device, FALSE for A-device.
> >> + * @vbus:	VBUS voltage in regulation.
> >> + *
> >>   * OTG hardware Inputs
> >>   *
> >>   *	Common inputs for A and B device
> >> @@ -122,7 +127,8 @@ enum otg_fsm_timer {
> >>   */
> >>  struct otg_fsm {
> >>  	/* Input */
> >> -	int id;
> >> +	int id;			/* DRD + OTG */
> >> +	int vbus;		/* DRD only */
> > 
> > Existing b_sess_vld can be also used for drd only case, no need create
> > a new flag.
> 
> b_sess_vld is a bit confusing to people not familiar with OTG.
> My suggestion is to use dedicated 'vbus' flag for DRD case
> for simplicity.
> 

Since OTG DRD is the subset in OTG FSM (FSM, data structure, APIs, etc),
I agree with Jun to reuse existing variables, and we can add some comments
for b_sess_vld if needed.


> > 
> >>  	int adp_change;
> >>  	int power_up;
> >>  	int a_srp_det;
> 
> cheers,
> -roger

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/