Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754515AbbGTCm2 (ORCPT ); Sun, 19 Jul 2015 22:42:28 -0400 Received: from ozlabs.org ([103.22.144.67]:57858 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbbGTCm1 convert rfc822-to-8bit (ORCPT ); Sun, 19 Jul 2015 22:42:27 -0400 Message-ID: <1437360145.6255.37.camel@neuling.org> Subject: Re: [PATCH] cxl: Remove use of macro DEFINE_PCI_DEVICE_TABLE From: Michael Neuling To: Vaishali Thakkar Cc: Ian Munsie , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 20 Jul 2015 12:42:25 +1000 In-Reply-To: <20150719172352.GA14386@vaishali-Ideapad-Z570> References: <20150719172352.GA14386@vaishali-Ideapad-Z570> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 47 On Sun, 2015-07-19 at 22:53 +0530, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch that performs this transformation > is as follows: > > @@ > identifier a; > declarer name DEFINE_PCI_DEVICE_TABLE; > initializer i; > @@ > - DEFINE_PCI_DEVICE_TABLE(a) > + const struct pci_device_id a[] > = i; > > Signed-off-by: Vaishali Thakkar Looks good, thanks! Acked-by: Michael Neuling > --- > drivers/misc/cxl/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 32ad097..3ed0621 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -133,7 +133,7 @@ u8 cxl_afu_cr_read8(struct cxl_afu *afu, int cr, u64 off) > return (val >> ((off & 0x3) * 8)) & 0xff; > } > > -static DEFINE_PCI_DEVICE_TABLE(cxl_pci_tbl) = { > +static const struct pci_device_id cxl_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0477), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x044b), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x04cf), }, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/