Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217AbbGTDTZ (ORCPT ); Sun, 19 Jul 2015 23:19:25 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:35347 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755083AbbGTDTW (ORCPT ); Sun, 19 Jul 2015 23:19:22 -0400 Message-ID: <55AC68B2.6080905@hitachi.com> Date: Mon, 20 Jul 2015 12:19:14 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Namhyung Kim CC: Arnaldo Carvalho de Melo , Peter Zijlstra , linux-kernel@vger.kernel.org, Adrian Hunter , Ingo Molnar , Paul Mackerras , Jiri Olsa , Borislav Petkov , Hemant Kumar Subject: Re: [RFC PATCH perf/core v2 15/16] perf buildid-cache: Scan and import user SDT events to probe cache References: <20150715091352.8915.87480.stgit@localhost.localdomain> <20150715091537.8915.63535.stgit@localhost.localdomain> <20150719104612.GB25163@danjae.kornet> In-Reply-To: <20150719104612.GB25163@danjae.kornet> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2605 Lines: 83 On 2015/07/19 19:46, Namhyung Kim wrote: > On Wed, Jul 15, 2015 at 06:15:37PM +0900, Masami Hiramatsu wrote: >> perf buildid-cache --add scans given binary and add >> the SDT events to probe cache. It is possible to use the cached >> SDT events as other cached events (perf probe :=). > > That means lookup the cached SDT events only using event name, right? Right, > What if same event names are used by more than one providers? That's a good discussion point :) What I'm thinking is that the real SDT is always prior to other cached events. (currently not implemented yet) - if someone gives a same event name, it overwrites previous one. - if someone gives an event name same as existing SDT, it is not cached (or rejected) - if SDT scanned after cached same name events, SDT always overwrites the entry. So, the all SDT events will be treated as fixed events. Note that this will be happen if we agree SDT and probe share the same namespace :) >> >> e.g. >> ---- >> # perf buildid-cache --add /lib/libc-2.17.so >> # perf probe --cache --list | head -n 5 >> /usr/lib/libc-2.17.so (a6fb821bdf53660eb2c29f778757aef294d3d392): >> libc:setjmp=setjmp >> libc:longjmp=longjmp >> libc:longjmp_target=longjmp_target >> libc:memory_heap_new=memory_heap_new > > I expected something like this instead.. > > libc:memory_heap_new=new_heap+183 OK, that's much better :) > > > Thanks, > Namhyung > > >> # perf probe -x /usr/lib/libc-2.17.so \ >> -a libc:memory_heap_new=memory_heap_new >> Added new event: >> libc:memory_heap_new (on memory_heap_new >> in /usr/lib/libc-2.17.so) >> >> You can now use it in all perf tools, such as: >> >> perf record -e libc:memory_heap_new -aR sleep 1 >> >> # perf probe -l >> libc:memory_heap_new (on new_heap+183 in /usr/lib/libc-2.17.so) >> ---- >> >> Note that SDT event entries in probe-cache file is somewhat different >> from normal cached events. Normal one starts with "#", but SDTs are >> starting with "%". >> >> Signed-off-by: Masami Hiramatsu > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/