Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569AbbGTHS0 (ORCPT ); Mon, 20 Jul 2015 03:18:26 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:60543 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753896AbbGTHSY (ORCPT ); Mon, 20 Jul 2015 03:18:24 -0400 From: Alexander Stein To: Jianwei Wang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, airlied@linux.ie, daniel.vetter@ffwll.ch, mark.yao@rock-chips.com, scottwood@freescale.com, thierry.reding@gmail.com, Jianwei Wang , Alison Wang , Xiubo Li Subject: Re: [PATCH v10 1/5] drm/layerscape: Add Freescale DCU DRM driver Date: Mon, 20 Jul 2015 09:18:16 +0200 Message-ID: <2160582.6fH0nmeH2v@ws-stein> User-Agent: KMail/4.14.8 (Linux/4.0.5-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1437129543-8037-1-git-send-email-jianwei.wang@freescale.com> References: <1437129543-8037-1-git-send-email-jianwei.wang@freescale.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 51 On Friday 17 July 2015 18:38:59, Jianwei Wang wrote: > [...] > +static const struct regmap_config fsl_dcu_regmap_config = { > + .reg_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, > +}; This defaults to REGCACHE_NONE which in the end sets regmap.cache_only = true. > [...] > +#ifdef CONFIG_PM_SLEEP > +static int fsl_dcu_drm_pm_suspend(struct device *dev) > +{ > + struct fsl_dcu_drm_device *fsl_dev = dev_get_drvdata(dev); > + > + if (!fsl_dev) > + return 0; > + > + drm_kms_helper_poll_disable(fsl_dev->drm); > + regcache_cache_only(fsl_dev->regmap, true); This should raise a warning (see http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/base/regmap/regcache.c#n472) as map->cache_bypass is set because of REGCACHE_NONE. I think you set the cache_type to REGCACHE_FLAT, but neither _LZO or _RBTREE (see https://lkml.org/lkml/2015/7/16/552 for that) Best regards, Alexander -- Dipl.-Inf. Alexander Stein SYS TEC electronic GmbH alexander.stein@systec-electronic.com Legal and Commercial Address: Am Windrad 2 08468 Heinsdorfergrund Germany Office: +49 (0) 3765 38600-11xx Fax: +49 (0) 0) 3765 38600-41xx Managing Directors: Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt; Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp Commercial Registry: Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/