Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755764AbbGTH0f (ORCPT ); Mon, 20 Jul 2015 03:26:35 -0400 Received: from mail-pd0-f195.google.com ([209.85.192.195]:36849 "EHLO mail-pd0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbbGTH0d (ORCPT ); Mon, 20 Jul 2015 03:26:33 -0400 Date: Mon, 20 Jul 2015 15:26:29 +0800 From: Minfei Huang To: Minfei Huang Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, tony.luck@intel.com, wangnan0@huawei.com, david.vrabel@citrix.com, yinghai@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mm: Assign the initail value to the pmd_idx Message-ID: <20150720072629.GA46717@huangminfeis-MacBook-Pro.local> References: <1436703522-29552-1-git-send-email-mhuang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436703522-29552-1-git-send-email-mhuang@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 41 ping. Can someone help review this patch? Thanks Minfei On 07/12/15 at 08:18P, Minfei Huang wrote: > From: Minfei Huang > > The variable pmd_idx is undefined, when we try to start the loop to > calculate the page. > > Assign the proper value which indexes the start address to make it work > well. > > Signed-off-by: Minfei Huang > --- > arch/x86/mm/init_32.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c > index 8340e45..68aec42 100644 > --- a/arch/x86/mm/init_32.c > +++ b/arch/x86/mm/init_32.c > @@ -137,6 +137,7 @@ page_table_range_init_count(unsigned long start, unsigned long end) > > vaddr = start; > pgd_idx = pgd_index(vaddr); > + pmd_idx = pmd_index(vaddr); > > for ( ; (pgd_idx < PTRS_PER_PGD) && (vaddr != end); pgd_idx++) { > for (; (pmd_idx < PTRS_PER_PMD) && (vaddr != end); > -- > 2.2.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/