Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbbGTIGI (ORCPT ); Mon, 20 Jul 2015 04:06:08 -0400 Received: from smtp.transmode.se ([31.15.61.139]:55860 "EHLO smtp.transmode.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755821AbbGTIGD convert rfc822-to-8bit (ORCPT ); Mon, 20 Jul 2015 04:06:03 -0400 From: Joakim Tjernlund To: "linuxppc-dev@lists.ozlabs.org" , "netdev@vger.kernel.org" , "madalin.bucur@freescale.com" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Topic: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Index: AQHQbJhB2jZpM8hxyUOfzf/67LKfqZ3kh+UAgAAAugA= Date: Mon, 20 Jul 2015 07:57:06 +0000 Message-ID: <1437379026.10831.14.camel@transmode.se> References: <1427905196-27778-1-git-send-email-madalin.bucur@freescale.com> <1437378870.10831.12.camel@transmode.se> In-Reply-To: <1437378870.10831.12.camel@transmode.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.16.4 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.168.200.4] Content-Type: text/plain; charset=US-ASCII Content-ID: <52AB016A5E264742BA88C9CBA3200037@transmode.com> Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 40 On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote: > On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote: > > This introduces the Freescale Data Path Acceleration Architecture > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > > the Freescale DPAA QorIQ platforms. > > > > Signed-off-by: Madalin Bucur > > --- > .... > > + net_dev = alloc_etherdev_mq(sizeof(*priv), DPAA_ETH_TX_QUEUES); > > + if (!net_dev) { > > + dev_err(dev, "alloc_etherdev_mq() failed\n"); > > + goto alloc_etherdev_mq_failed; > > + } > > + > > + snprintf(net_dev->name, IFNAMSIZ, "fm%d-mac%d", > > + dpa_mac_fman_index_get(pdev), > > + dpa_mac_hw_index_get(pdev)); > > Should ethernet drivers dictate interface name in user space nowadays? > I would prefer if you didn't. > > I am trying these patches on a custom T1042 board using Linux 4.1 but > I cannot get Fixed PHY to work: > libphy: PHY fixed-0:00 not found > fsl_dpa dpaa-ethernet.2 eth2: Could not connect to PHY fixed-0:00 > fsl_dpa dpaa-ethernet.2 eth2: init_phy() = -19 > > Not sure what I have missed here, any ideas? I meant I am using http://git.freescale.com/git/cgit.cgi/ppc/upstream/linux.git/ on top of 4.1 Jocke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/