Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299AbbGTI4Y (ORCPT ); Mon, 20 Jul 2015 04:56:24 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:40741 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756622AbbGTI4U (ORCPT ); Mon, 20 Jul 2015 04:56:20 -0400 Message-ID: <55ACB79A.3010101@atmel.com> Date: Mon, 20 Jul 2015 10:55:54 +0200 From: Cyrille Pitchen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle CC: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller References: <1437123868.24981.7.camel@tiscali.nl> In-Reply-To: <1437123868.24981.7.camel@tiscali.nl> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 37 Hi Paul, I've removed the ".bus = &plaform_bus_type" for the next series. Thank you for the explanation and the review :) Best Regards, Cyrille Le 17/07/2015 11:04, Paul Bolle a écrit : > On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote: >> --- /dev/null >> +++ b/drivers/mtd/spi-nor/atmel-quadspi.c > >> +static struct platform_driver atmel_qspi_driver = { >> + .driver = { >> + [...] >> + .bus = &platform_bus_type, >> + [...] >> +}; >> +module_platform_driver(atmel_qspi_driver); > > Nit: on module init this will basically do > __platform_driver_register(&atmel_qspi_driver, THIS_MODULE); > > which will again set bus to &platform_bus_type. So you might as well > drop that line. > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/