Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198AbbGTKUH (ORCPT ); Mon, 20 Jul 2015 06:20:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47518 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752578AbbGTKUD (ORCPT ); Mon, 20 Jul 2015 06:20:03 -0400 Date: Mon, 20 Jul 2015 12:15:27 +0200 From: Maxime Ripard To: Josef Gajdusek Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM: dts: sun4i: Add Iteaduino Plus A10 Message-ID: <20150720101527.GV28632@lukather> References: <20150719134501.GA19235@maud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kgkihKxW3Un7xdgA" Content-Disposition: inline In-Reply-To: <20150719134501.GA19235@maud> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8283 Lines: 298 --kgkihKxW3Un7xdgA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks for your patch. On Sun, Jul 19, 2015 at 03:45:03PM +0200, Josef Gajdusek wrote: > Iteaduino Plus A10 is a breakout board + Itead Core A10. Is there multiple breakout boards available for that module? > It features 1GB RAM, has most of the A10 pins on a .1" header, 2 USB > ports, 1 OTG USB port, Ethernet, HDMI, SATA, Speaker/Microphone > 3.5mm jacks and an SD card slot. >=20 > Link to manufacturer wiki: http://wiki.iteadstudio.com/Iteaduino_Plus_A10= /A20 Please don't put such links in the commit description. Valid URLs come and go, the git history doesn't. > Signed-off-by: Josef Gajdusek > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun4i-a10-iteaduino-plus.dts | 202 +++++++++++++++++++= ++++++ > 2 files changed, 203 insertions(+) > create mode 100644 arch/arm/boot/dts/sun4i-a10-iteaduino-plus.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index adb1826..6104ed1 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -529,6 +529,7 @@ dtb-$(CONFIG_MACH_SUN4I) +=3D \ > sun4i-a10-hackberry.dtb \ > sun4i-a10-hyundai-a7hd.dtb \ > sun4i-a10-inet97fv2.dtb \ > + sun4i-a10-iteaduino-plus.dts \ > sun4i-a10-jesurun-q5.dtb \ > sun4i-a10-marsboard.dtb \ > sun4i-a10-mini-xplus.dtb \ > diff --git a/arch/arm/boot/dts/sun4i-a10-iteaduino-plus.dts b/arch/arm/bo= ot/dts/sun4i-a10-iteaduino-plus.dts > new file mode 100644 > index 0000000..985e155 > --- /dev/null > +++ b/arch/arm/boot/dts/sun4i-a10-iteaduino-plus.dts we try to have a DT name that is ---.dts Which in this case would be sun4i-a10-itead-iteaduino-plus.dts > @@ -0,0 +1,202 @@ > +/* > + * Copyright 2015 Josef Gajdusek > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun4i-a10.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > + > +/ { > + model =3D "Iteaduino Plus A10"; > + compatible =3D "itead,iteaduino-plus-a10", "allwinner,sun4i-a10"; > + > + aliases { > + serial0 =3D &uart0; > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > +}; > + > +&ahci { > + target-supply =3D <®_ahci_5v>; > + status =3D "okay"; > +}; > + > +&cpu0 { > + cpu-supply =3D <®_dcdc2>; > +}; > + > +&ehci0 { > + status =3D "okay"; > +}; > + > +&ehci1 { > + status =3D "okay"; > +}; > + > +&emac { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&emac_pins_a>; > + phy =3D <&phy1>; > + status =3D "okay"; > +}; > + > +&emac_sram { > + status =3D "okay"; > +}; > + > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins_a>; > + status =3D "okay"; > + > + axp209: pmic@34 { > + reg =3D <0x34>; > + interrupts =3D <0>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pins_a>; > + status =3D "okay"; > +}; > + > +&i2c2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c2_pins_a>; > + status =3D "okay"; > +}; > + > +&ir0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&ir0_rx_pins_a>; > + status =3D "okay"; > +}; > + > +&mdio { > + status =3D "okay"; > + > + phy1: ethernet-phy@1 { > + reg =3D <1>; > + }; > +}; > + > +&mmc0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>; > + vmmc-supply =3D <®_vcc3v3>; > + bus-width =3D <4>; > + cd-gpios =3D <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ > + cd-inverted; > + status =3D "okay"; > +}; > + > +&ohci0 { > + status =3D "okay"; > +}; > + > +&ohci1 { > + status =3D "okay"; > +}; > + > +®_ahci_5v { > + status =3D "okay"; > +}; > + > +#include "axp209.dtsi" > + > +®_dcdc2 { > + regulator-always-on; > + regulator-min-microvolt =3D <1000000>; > + regulator-max-microvolt =3D <1450000>; > + regulator-name =3D "vdd-cpu"; > +}; > + > +®_dcdc3 { > + regulator-always-on; > + regulator-min-microvolt =3D <1000000>; > + regulator-max-microvolt =3D <1400000>; > + regulator-name =3D "vdd-int-dll"; > +}; > + > +®_ldo1 { > + regulator-name =3D "vdd-rtc"; > +}; > + > +®_ldo2 { > + regulator-always-on; > + regulator-min-microvolt =3D <3000000>; > + regulator-max-microvolt =3D <3000000>; > + regulator-name =3D "avcc"; > +}; > + > +®_usb1_vbus { > + status =3D "okay"; > +}; > + > +®_usb2_vbus { > + status =3D "okay"; > +}; > + > +&spi0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi0_pins_a>, > + <&spi0_cs0_pins_a>; > + status =3D "okay"; > +}; > + > +&uart0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart0_pins_a>; > + status =3D "okay"; > +}; > + > +&usbphy { > + usb1_vbus-supply =3D <®_usb1_vbus>; > + usb2_vbus-supply =3D <®_usb2_vbus>; > + status =3D "okay"; > +}; Looks good otherwise, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --kgkihKxW3Un7xdgA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVrMo/AAoJEBx+YmzsjxAgHEUP/20MHfCPE1GLwqmLaRICu5QE DoeiEKL41UF25zJDjMIzVVld4JB3kFJ8UXXf+XDQwWy7hhl8i4gkvtLWTEg1mgTR ayGoe25kvPEdJrV8H1YwvRgU+0SQ8fEacX70X9kmqVBGsqBfhnftBir00TuWjycX Y/QPzaW3Pk7yEbWFexai43GVxTUQtQBuHXiYv3MMX/qi3QT9ZEZijcB1P47Ge3fR BD2S+2P8NMT7Q9C+d6CloYL7CVnzMyqSwl1A2niMQc4NHantYH8dVzAUmrQgEqLa mB95gyvJA4ogur3PcWD9Mlflat/42yogyTWEE/Em3ijtK0jAl7keIufPj0yUEWma 2krWJdq51FK/G8B3oQXOSErimPv4rmof87/XBtW2FxZg4umc9D3FrrO5WQuy/MKN CGIr1Av4NmUBud87pv7PMoX4+LwYgjhEAwMYB4E8SEOma/Joj6xOVWcQDCN2C8bD AsUaSpss7kqGkDJN8sxqPwNLUCRZuskZKNchc+YDDXVNfVNfwX483dvxeDi3y5fE nC3e5/Q0+CJ+uZICsF00SVs+MKf84cSR9tyZc1XIw4FSnmTj1WfEdcUKFsWANE9M T+PjSWfq2vf8/HU0rSiVxedMD0EfiTGUZtZbBIv3csf5xNu17RmiX+tDo1Vnnm3C bvok6b4BrOHw/ANfetul =kWr2 -----END PGP SIGNATURE----- --kgkihKxW3Un7xdgA-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/