From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Topic: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Index: AQHQbJe2LWr01iCNrECqTTVPTBGDP53kqW4AgAAAugCAAESOIA==
Date: Mon, 20 Jul 2015 12:18:52 +0000
Message-ID: <BL2PR03MB5456302C77FAEC1AC60669CE6850@BL2PR03MB545.namprd03.prod.outlook.com>
References: <1427905196-27778-1-git-send-email-madalin.bucur@freescale.com>
	 <1437378870.10831.12.camel@transmode.se>
 <1437379026.10831.14.camel@transmode.se>
In-Reply-To: <1437379026.10831.14.camel@transmode.se>
Accept-Language: en-US
Content-Language: en-US
bl2pr03mb546: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2015 12:18:52.6075
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB546
X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB338;2:gScN/6jtbFp7l5MTNmKy5KyYMDBOl0mkmuf+DvqXDvH9bWbkZcayarY8b+BN9ki7;3:rysYd9RShayhGHm2DFwnSzJxG3cqwsrj66sIaSQAC1IFTC6TpDZwytZzR30sk5LwcVVPw/FC5nqaa0lTu5nxOpU51WMn0mHOacLSAkTkiXNkhzGpKsp0SkGwR+feAR7g4Jaa40ISmfhL8WhQY9EFuQ==;25:bI6WgWA50kUNgXe2dsTPHSfVQ55eTGmG+j7fOPCWgpMEAus/ijvihETK8vkGaMyAINRwdG+Y76b1W09r0bjvcu7UpoKezwQNFoZw8e8smJDv6Hvm7Cd2Ud4NoocPAPlE0kdaQlHXm+MJGUD6YLV5k/rF82spS4ybWvZK6n7nN2OzDo5nxszWxUDfY4v81pa0/ZWzKFEp0o0cr2r1xAcDvAS78c0q4/Il3iigZw9Y0A3K3Lku9xpnrssg7pySYxes9OEHkWfSHjHDqSqzjy+nOg==
X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB338;20:VBpK671ZA8hshJ/AtE2e49xln/cIFKPRk/Ec/lsvHVjrnp6iL6aXnpuRjJ3lwMtNE1IuYp9jw/07phCxtGe8VWFEyOeX3j5fwvmdRZdSqkfpb/8mD9aBEq+X47/2SzZ/TzlSxDPcqBesrfz6+LfO2TTcMwTE+gW5sMDA3WTF4O5/KNtDeR/PMK3bTw+d6pSjQbHDOuMNkDoSkkps4N4QTW+6sbEaPwgCJwIUgy4l8pInohPT6rB60UZmLzsCd4oD2kSQFRFgu1OwFvPF0oFFqqwJCBgOox47jqqD2W+by2y/h4tGqjXCgB9UvGPI4AbINt7ai2I76HBc4mlB0HzbhBqxmGpl8evLTpdxlgV/+47MPngJVUfvJwlhYBIh4tcd1BhhhygulVEfgesVGcVp+8EOvFSovkUgpWJSdTjYhGM7XpXYzwXlvUquV5QV/gr2QvtuTgTqAjs4uODMsuM8aM0Xynu+5cocxXdFrfm43IsFJIRrhxgQ2TbP005ytT7aWVfkRIEWXokCQXKYASYvVR8chVtF9yXt4GT8pu8M1jdD2bCYHcZv0Rs89Wxf41dcId+W4CBQaek9Rw/8nBF6CwA4+X4+mHsEqjp6YxFe+IE=;23:W1NGKI6Cj9MFoGXOKRzEkwHMnLCDF/yxk56qODM93UFSBonUItmQz9NMiv1ZnPS7ihv+5pMR2SUpyyaRBM1Y1BSaEynkh+I8zXPdDu7IsyVWQB8vuPrk+fGSPBxWznPvUl8DhA4Qfw1lyCT3VLSjA3KP8y1jdZS0BlDKEeWNhnm3+I9ey86QRQugizYU13tvy2yaxXyvtcKHjph8ME8u1aRsFmm1VjfLXunR5GLKjatRu4lk9p+TGuy8IFat+bGc
BL2PR03MB338: X-MS-Exchange-Organization-RulesExecuted
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2760
Lines: 66

Hi Joakim

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> Sent: Monday, July 20, 2015 10:57 AM
> To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Bucur Madalin-
> Cristian-B32716
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
> 
> On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote:
> > On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> > > This introduces the Freescale Data Path Acceleration Architecture
> > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> > > the Freescale DPAA QorIQ platforms.
> > >
> > > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> > > ---
> > ....
> > > +	snprintf(net_dev->name, IFNAMSIZ, "fm%d-mac%d",
> > > +		 dpa_mac_fman_index_get(pdev),
> > > +		 dpa_mac_hw_index_get(pdev));
> >
> > Should ethernet drivers dictate interface name in user space nowadays?
> > I would prefer if you didn't.

The preformatted interface name was thought as a helper for quick interface
identification. It also ensures constant naming of the interfaces, i.e. if you
add/remove PCI network cards. One can make use of udev rules to override
default interface names ("eth%d") in userspace.

Another reason for using this is that the interface name was also used for the
debugfs file name and when compiling dpaa_eth as a module there was a
problem with udev concurrently renaming interfaces from eth0 to something
like fmx-macy, making the next probed DPAA interface temporarily get the
eth0 name (before being renamed fmx-macw). Subsequently,
the debugfs_create_file(net_dev->name,...) call failed because of duplicated
names.

If this is considered more of a bug than a feature, I can remove it and only change
the naming of the debugfs entries to avoid the udev issue.

> > I am trying these patches on a custom T1042 board using Linux 4.1 but
> > I cannot get Fixed PHY to work:
> > libphy: PHY fixed-0:00 not found
> > fsl_dpa dpaa-ethernet.2 eth2: Could not connect to PHY fixed-0:00
> > fsl_dpa dpaa-ethernet.2 eth2: init_phy() = -19
> >
> > Not sure what I have missed here, any ideas?
> 
> I meant I am using
> http://git.freescale.com/git/cgit.cgi/ppc/upstream/linux.git/
> on top of 4.1
> 
>  Jocke

Please make sure you have CONFIG_FIXED_PHY=y in your .config.
Can you please share the device tree part where you've added the fixed-link entry?

Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/