Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754994AbbGTM3k (ORCPT ); Mon, 20 Jul 2015 08:29:40 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34154 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754203AbbGTM3j (ORCPT ); Mon, 20 Jul 2015 08:29:39 -0400 From: Sudip Mukherjee To: Daniel Vetter , Jani Nikula , David Airlie Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Sudip Mukherjee Subject: [PATCH] drm/i915: fix possible null pointer dereference Date: Mon, 20 Jul 2015 17:59:29 +0530 Message-Id: <1437395369-749-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 35 We were dereferencing dev first and then checking if it is NULL. Lets check for NULL first and then dereference. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index bc817da..f316e49 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -4100,12 +4100,13 @@ static int i915_displayport_test_active_show(struct seq_file *m, void *data) { struct drm_device *dev = m->private; struct drm_connector *connector; - struct list_head *connector_list = &dev->mode_config.connector_list; + struct list_head *connector_list; struct intel_dp *intel_dp; if (!dev) return -ENODEV; + connector_list = &dev->mode_config.connector_list; list_for_each_entry(connector, connector_list, head) { if (connector->connector_type != -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/