Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932220AbbGTNPi (ORCPT ); Mon, 20 Jul 2015 09:15:38 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56214 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbbGTNPg convert rfc822-to-8bit (ORCPT ); Mon, 20 Jul 2015 09:15:36 -0400 From: Juergen Borleis Organization: Pengutronix e.K. To: kernel@pengutronix.de Subject: Re: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use Date: Mon, 20 Jul 2015 15:18:58 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: Peter Hurley , Stefan Wahren , "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org References: <1437032458-8577-1-git-send-email-jbe@pengutronix.de> <201507201004.02646.jbe@pengutronix.de> <55ACF0E5.6040107@hurleysoftware.com> In-Reply-To: <55ACF0E5.6040107@hurleysoftware.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201507201518.58720.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 26 Hi Peter, On Monday 20 July 2015 15:00:21 Peter Hurley wrote: > [...] > > mxs_auart_reset() is a bad name from the beginning. But I just wanted to > > keep this change small and only change things that are really required. I > > will try with a V4. > > ISTM this should be split into 2 or 3 separate patches: > 1. Rename mxs_auart_reset() > 2. Fix stale rx on re-open > 3. Reset @ probe Okay. Regards, Juergen -- Pengutronix e.K.                              | Juergen Borleis             | Industrial Linux Solutions                    | http://www.pengutronix.de/  | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/