Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756013AbbGTNhX (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jul 2015 09:37:23 -0400
Received: from mail9.hitachi.co.jp ([133.145.228.44]:37952 "EHLO
	mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751681AbbGTNhV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jul 2015 09:37:21 -0400
Message-ID: <55ACF98A.9070307@hitachi.com>
Date: Mon, 20 Jul 2015 22:37:14 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Tom Zanussi <tom.zanussi@linux.intel.com>, rostedt@goodmis.org
CC: daniel.wagner@bmw-carit.de, namhyung@kernel.org, josh@joshtriplett.org,
        andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 08/22] tracing: Add 'hist' event trigger command
References: <cover.1437066836.git.tom.zanussi@linux.intel.com> <4912007a2c10ba09a34e5edafa7325377a4795d5.1437066836.git.tom.zanussi@linux.intel.com>
In-Reply-To: <4912007a2c10ba09a34e5edafa7325377a4795d5.1437066836.git.tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2496
Lines: 53

Hi Tom,

On 2015/07/17 2:22, Tom Zanussi wrote:

> @@ -3782,6 +3785,32 @@ static const char readme_msg[] =
>  	"\t   To remove a trigger with a count:\n"
>  	"\t     echo '!<trigger>:0 > <system>/<event>/trigger\n"
>  	"\t   Filters can be ignored when removing a trigger.\n"
> +#ifdef CONFIG_HIST_TRIGGERS
> +	"      hist trigger\t- If set, event hits are aggregated into a hash table\n"
> +	"\t    Format: hist:keys=<field1>\n"
> +	"\t            [:size=#entries]\n"
> +	"\t            [if <filter>]\n\n"
> +	"\t    When a matching event is hit, an entry is added to a hash\n"
> +	"\t    table using the key named.  Keys correspond to fields in the\n"
> +	"\t    event's format description.  On an event hit, the value of a\n"
> +	"\t    sum called 'hitcount' is incremented, which is simply a count\n"
> +	"\t    of event hits.  Keys can be any field.\n\n"
> +	"\t    Reading the 'hist' file for the event will dump the hash\n"
> +	"\t    table in its entirety to stdout.  Each printed hash table\n"
> +	"\t    entry is a simple list of the keys and values comprising the\n"
> +	"\t    entry; keys are printed first and are delineated by curly\n"
> +	"\t    braces, and are followed by the set of value fields for the\n"
> +	"\t    entry.  Numeric fields are displayed as base-10 integers.\n"
> +	"\t    By default, the size of the hash table is 2048 entries.  The\n"
> +	"\t    'size' param can be used to specify more or fewer than that.\n"
> +	"\t    The units are in terms of hashtable entries - if a run uses\n"
> +	"\t    more entries than specified, the results will show the number\n"
> +	"\t    of 'drops', the number of hits that were ignored.  The size\n"
> +	"\t    should be a power of 2 between 128 and 131072 (any non-\n"
> +	"\t    power-of-2 number specified will be rounded up).\n\n"
> +	"\t    The entries are sorted by 'hitcount' and the sort order is\n"
> +	"\t    'ascending'.\n\n"


Hmm, this seems too much about implementation of histogram. Could you shorten this
to be a half ?


Thank you,


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/