Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932807AbbGTOYL (ORCPT ); Mon, 20 Jul 2015 10:24:11 -0400 Received: from mailgw01.mediatek.com ([218.249.47.110]:52725 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932798AbbGTOYH (ORCPT ); Mon, 20 Jul 2015 10:24:07 -0400 X-Listener-Flag: 11101 Message-ID: <1437402240.11518.0.camel@mhfsdcap03> Subject: Re: [PATCH v2 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller From: chunfeng yun To: Roger Quadros CC: Mathias Nyman , Rob Herring , Mark Rutland , "Matthias Brugger" , Felipe Balbi , "Sascha Hauer" , , , , , Date: Mon, 20 Jul 2015 22:24:00 +0800 In-Reply-To: <559F82C7.5010202@ti.com> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-3-git-send-email-chunfeng.yun@mediatek.com> <559F82C7.5010202@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2224 Lines: 69 On Fri, 2015-07-10 at 11:31 +0300, Roger Quadros wrote: > Hi, > > On 08/07/15 12:41, Chunfeng Yun wrote: > > add a DT binding documentation of xHCI host controller for the > > MT8173 SoC from Mediatek. > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/usb/mt8173-xhci.txt | 27 ++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > new file mode 100644 > > index 0000000..94cec94 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > @@ -0,0 +1,27 @@ > > +MT65XX xhci > > + > > +The device node for Mediatek SOC usb3.0 host controller > > + > > +Required properties: > > + - compatible : supports "mediatek,mt8173-xhci" > > + - reg : Offset and length of registers > > + - interrupts : Interrupt mode, number and trigger mode > > + - reg-vusb33-supply: regulator of usb avdd3.3v > > + - reg-vbus-supply : regulator of vbus; > > General trend is to use -supply. > We already know it is a regulator so no need to add "reg-" > > So those two can be > > vusb33-supply: > vbus-supply: > Ok, thanks > > > + - usb-phy : the phy that xhci will bind > > + - usb3-lpm-capable: supports USB3 LPM > > + - clocks : must support all clocks that xhci needs > > + - clock-names: should be "sys_mac" for sys and mac clocks > > + > > +Example: > > +usb: usb30@11270000 { > > + compatible = "mediatek,mt8173-xhci"; > > + reg = <0 0x11270000 0 0x1000>; > > + interrupts = ; > > + reg-vusb33-supply = <&mt6397_vusb_reg>; > > + reg-vbus-supply = <&usb_p1_vbus>; > > + usb-phy = <&u3phy>; > > + usb3-lpm-capable; > > + clocks = <&topckgen CLK_TOP_USB30_SEL>; > > + clock-names = "sys_mac"; > > +}; > > > > cheers, > -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/