Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155AbbGTPAC (ORCPT ); Mon, 20 Jul 2015 11:00:02 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:34945 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbbGTO77 (ORCPT ); Mon, 20 Jul 2015 10:59:59 -0400 MIME-Version: 1.0 In-Reply-To: <1437403873.15139.5.camel@mtksdaap41> References: <1436348468-4126-1-git-send-email-chunfeng.yun@mediatek.com> <1436348468-4126-6-git-send-email-chunfeng.yun@mediatek.com> <1437403179.11518.10.camel@mhfsdcap03> <1437403873.15139.5.camel@mtksdaap41> From: Daniel Kurtz Date: Mon, 20 Jul 2015 22:59:38 +0800 X-Google-Sender-Auth: NDBv1J-RpGuyX2fQSvdViFMCAa0 Message-ID: Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 To: Yingjoe Chen Cc: chunfeng yun , Mark Rutland , "open list:OPEN FIRMWARE AND..." , Mathias Nyman , Sascha Hauer , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" , Felipe Balbi , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , "linux-arm-kernel@lists.infradead.org" , Roger Quadros Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 53 On Mon, Jul 20, 2015 at 10:51 PM, Yingjoe Chen wrote: > > Hi Daniel, Chunfeng, > > > On Mon, 2015-07-20 at 22:39 +0800, chunfeng yun wrote: >> Hi, >> >> On Tue, 2015-07-14 at 18:12 +0800, Daniel Kurtz wrote: > <...> >> > > + >> > > + usb_p1_vbus: fixedregulator@0 { >> > >> > Why @0 ? >> It is the first fixed regulator, so set it to 0 as a index. >> I will remove it later > > Since this name should be unique, I think we should use gpio number as > address for fixedregulator in case we need other fixedregulators. So > this could be: > > usb_p1_vbus: fixedregulator@130 { > > Also, we should sort according to the address(gpio number) for these > nodes. Does this make sense? Yes - that makes some sense. But, a quick check of other "fixedregulator@" nodes in arch/arm/boot/dts/ shows that mostly they use @0 , @1. So, I think the original patch is probably fine. Sorry for the noise, -Dan > > Joe.C > >> > >> > > + compatible = "regulator-fixed"; >> > > + regulator-name = "usb_vbus"; >> > > + regulator-min-microvolt = <5000000>; >> > > + regulator-max-microvolt = <5000000>; >> > > + gpio = <&pio 130 GPIO_ACTIVE_HIGH>; >> > > + enable-active-high; >> > > + }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/