Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932936AbbGTPfI (ORCPT ); Mon, 20 Jul 2015 11:35:08 -0400 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:46558 "EHLO resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbbGTPfD (ORCPT ); Mon, 20 Jul 2015 11:35:03 -0400 Date: Mon, 20 Jul 2015 10:35:02 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Baoquan He cc: tj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] percpu: add macro PCPU_CHUNK_AREA_IN_USE In-Reply-To: <1437404130-5188-3-git-send-email-bhe@redhat.com> Message-ID: References: <1437404130-5188-1-git-send-email-bhe@redhat.com> <1437404130-5188-3-git-send-email-bhe@redhat.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 641 Lines: 14 On Mon, 20 Jul 2015, Baoquan He wrote: > chunk->map[] contains of each area. Now add a > new macro PCPU_CHUNK_AREA_IN_USE and use it as the in-use flag to > replace all magic number '1'. Hmmm... This is a bitflag and the code now looks like there is some sort of bitmask that were are using. Use bitops or something else that clearly implies that a bit is flipped instead? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/