Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756037AbbGTPya (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jul 2015 11:54:30 -0400
Received: from mail-pd0-f174.google.com ([209.85.192.174]:36498 "EHLO
	mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755040AbbGTPy1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jul 2015 11:54:27 -0400
Date: Tue, 21 Jul 2015 00:52:07 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
        Jiri Olsa <jolsa@kernel.org>, Borislav Petkov <bp@suse.de>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH perf/core v2 15/16] perf buildid-cache: Scan and
 import user SDT events to probe cache
Message-ID: <20150720155207.GB9265@danjae.kornet>
References: <20150715091352.8915.87480.stgit@localhost.localdomain>
 <20150715091537.8915.63535.stgit@localhost.localdomain>
 <20150719104612.GB25163@danjae.kornet>
 <55AC68B2.6080905@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <55AC68B2.6080905@hitachi.com>
User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1796
Lines: 48

On Mon, Jul 20, 2015 at 12:19:14PM +0900, Masami Hiramatsu wrote:
> On 2015/07/19 19:46, Namhyung Kim wrote:
> > On Wed, Jul 15, 2015 at 06:15:37PM +0900, Masami Hiramatsu wrote:
> >> perf buildid-cache --add <binary> scans given binary and add
> >> the SDT events to probe cache. It is possible to use the cached
> >> SDT events as other cached events (perf probe <provider>:<event>=<event>).
> > 
> > That means lookup the cached SDT events only using event name, right?
> 
> Right,
> 
> > What if same event names are used by more than one providers?
> 
> That's a good discussion point :)
> 
> What I'm thinking is that the real SDT is always prior to other
> cached events. (currently not implemented yet)
>  - if someone gives a same event name, it overwrites previous one.
>  - if someone gives an event name same as existing SDT, it is not
>    cached (or rejected)
>  - if SDT scanned after cached same name events, SDT always overwrites
>    the entry.

I'm thinking about allowing same name for different events.  IMHO it's
possible to have same SDT names for some reason - i.e. having multiple
versions of same program, similar (but different) binaries have same
event names, or even in a single bianry it might have same event names
but different provider names.

In that case, I think perf probe (or record) simply can do the job for
every matching events.

> 
> So, the all SDT events will be treated as fixed events.
> 
> Note that this will be happen if we agree SDT and probe share the
> same namespace :)

Right.

Thanks,
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/