Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756150AbbGTRII (ORCPT ); Mon, 20 Jul 2015 13:08:08 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.109]:52705 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbbGTRIF convert rfc822-to-8bit (ORCPT ); Mon, 20 Jul 2015 13:08:05 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-6.tower-194.messagelabs.com!1437412080!30229989!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Alexandre Belloni CC: DEVICETREE , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXKERNEL , Mark Rutland , "Pawel Moll" , RTCLINUX , Rob Herring , Alessandro Zummo , "David Dajun Chen" , Lee Jones , Samuel Ortiz , Support Opensource Subject: RE: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC Thread-Topic: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC Thread-Index: AQHQuhwD4Qxf167igkiZ9VY3PbqXpJ3gUO+AgARWLoA= Date: Mon, 20 Jul 2015 17:08:00 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B253DAD@SW-EX-MBX02.diasemi.com> References: <20150717234737.GJ3487@piout.net> In-Reply-To: <20150717234737.GJ3487@piout.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 47 On 18 July 2015 00:48, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > > From: S Twiss > > > > Add device tree bindings for the DA9062 RTC driver component > > > > Signed-off-by: Steve Twiss [...] > > +- rtc : This node defines settings required for the Real-Time Clock associated > > + with the DA9062. There are currently no entries in this binding, however > > + compatible = "dlg,da9062-rtc" should be added if a node is created. [...] > > @@ -55,6 +60,10 @@ Example: > > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > > interrupt-controller; > > > > + rtc { > > + compatible = "dlg,da9062-rtc"; > > + }; > > + > > Are those subnodes even parsed? As the parent node is not compatible > with "simple-bus" or "simple-mfd", I guess not. You driver is probed > from the mfd_cells in da9063-core.c Hi Alexandre, If I miss out the compatible line for the RTC in the DTSI for DA9062, or is I alter it so it does not match the string specified in the DA9063 RTC driver, the DA9063 RTC driver will not be probed for the DA9062 compatibility. The RTC compatible = "dlg,da9062-rtc" is essential in this case. [...] Regards, Stephen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/