Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267253AbTBLOZu>; Wed, 12 Feb 2003 09:25:50 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267254AbTBLOZu>; Wed, 12 Feb 2003 09:25:50 -0500
Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:520 "EHLO
	atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP
	id <S267253AbTBLOZs>; Wed, 12 Feb 2003 09:25:48 -0500
Date: Wed, 12 Feb 2003 15:35:35 +0100
From: Pavel Machek <pavel@suse.cz>
To: Ducrot Bruno <poup@poupinou.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557
Message-ID: <20030212143535.GG13327@atrey.karlin.mff.cuni.cz>
References: <20030211131151.GA1262@k3.hellgate.ch> <20030211132132.GA20750@atrey.karlin.mff.cuni.cz> <20030211135910.GB25632@poup.poupinou.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030211135910.GB25632@poup.poupinou.org>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1015
Lines: 34

Hi!

> > > Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
> > > (using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
> > > check with older 2.5.x indicates this problem has been around for a
> > > while.
> > 
> > 
> > It works for me in 2.5.59. I'm now downloading 2.5.60.
> > 
> > Replacing 
> > 
> > BUG_ON (HWGROUP(drive)->handler);
> > 
> > with
> > 
> > while(HWGROUP(drive)->handler);
> > 
> > 
> > might do the trick, but also might corrupt the data badly.
> 
> IMHO s/might/will/g

It should be okay if he forces fsck after the experiments. But yes, it
is pretty risky.
								Pavel
-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/