From: KY Srinivasan <kys@microsoft.com>
To: Dexuan Cui <decui@microsoft.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH 5/5] Drivers: hv: vmbus: Implement a clocksource based on
 the TSC page
Thread-Topic: [PATCH 5/5] Drivers: hv: vmbus: Implement a clocksource based on
 the TSC page
Thread-Index: AQHQwpGi+LWMWfCe/EqHiPkutq1H1J3kRgiAgABtwZA=
Date: Mon, 20 Jul 2015 18:50:52 +0000
Message-ID: <BY2PR0301MB1654FA5967C5A3630A83F5C2A0850@BY2PR0301MB1654.namprd03.prod.outlook.com>
References: <1437363419-3511-1-git-send-email-kys@microsoft.com>
 <1437363447-3554-1-git-send-email-kys@microsoft.com>
 <1437363447-3554-5-git-send-email-kys@microsoft.com>
 <bd8c7f484f2c475b9020f06166134df6@SIXPR30MB031.064d.mgd.msft.net>
In-Reply-To: <bd8c7f484f2c475b9020f06166134df6@SIXPR30MB031.064d.mgd.msft.net>
Accept-Language: en-US
Content-Language: en-US
by2pr0301mb1655: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2015 18:50:52.5614
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1655
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2042
Lines: 65


> -----Original Message-----
> From: Dexuan Cui
> Sent: Monday, July 20, 2015 5:14 AM
> To: KY Srinivasan; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com
> Subject: RE: [PATCH 5/5] Drivers: hv: vmbus: Implement a clocksource based
> on the TSC page
> 
> > From: devel [mailto:driverdev-devel-bounces...linuxdriverproject.org] On
> Behalf
> > Of K. Y. Srinivasan
> > Sent: Monday, July 20, 2015 11:37
> >
> > The current Hyper-V clock source is based on the per-partition reference
> counter
> > and this counter is being accessed via s synthetic MSR -
> > HV_X64_MSR_TIME_REF_COUNT.
> > Hyper-V has a more efficient way of computing the per-partition reference
> > counter value that does not involve reading a synthetic MSR. We
> implement
> > a time source based on this mechanism.
> > ...
> > diff --git a/arch/x86/include/uapi/asm/hyperv.h
> > @@ -183,6 +233,22 @@ int hv_init(void)
> >
> >  	hv_context.hypercall_page = virtaddr;
> >
> > +#ifdef CONFIG_X86_64
> > +	if (ms_hyperv.features &
> HV_X64_MSR_REFERENCE_TSC_AVAILABLE) {
> > +		va_tsc = __vmalloc(PAGE_SIZE, GFP_KERNEL,
> PAGE_KERNEL);
> > +		if (!va_tsc)
> > +			goto cleanup;
> > +		hv_context.tsc_page = va_tsc;
> > +
> > +		rdmsrl(HV_X64_MSR_REFERENCE_TSC, tsc_msr.as_uint64);
> > +
> > +		tsc_msr.enable = 1;
> > +		tsc_msr.guest_physical_address = vmalloc_to_pfn(va_tsc);
> > +
> > +		wrmsrl(HV_X64_MSR_REFERENCE_TSC, tsc_msr.as_uint64);
> > +		clocksource_register_hz(&hyperv_cs_tsc,
> NSEC_PER_SEC/100);
> > +	}
> > +#endif
> 
> Should we disable the mechanism and vfree() the page in hv_cleanup() for
> kexec/kdump?

Thanks Dexuan. I will update the patch and resend.

Regards,

K. Y
> 
> -- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/