Date: Mon, 20 Jul 2015 21:25:31 +0200
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, benh@kernel.crashing.org,
        davem@davemloft.net
Subject: Re: [PATCH] iommu-common: Do not use 64 bit  constant
 0xffffffffffffffffl for computing align_mask
Message-ID: <20150720192531.GB19855@oracle.com>
References: <20150719121653.GA30645@oracle.com>
 <20150719152724.GB3729@roeck-us.net>
 <874mkzevz4.fsf@rasmusvillemoes.dk>
 <55AC55AD.6070608@roeck-us.net>
 <87oaj6ogox.fsf@rasmusvillemoes.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87oaj6ogox.fsf@rasmusvillemoes.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 765
Lines: 19

On (07/20/15 19:57), Rasmus Villemoes wrote:
> I highly doubt it. The result is truncated to unsigned long
> anyway. Assuming align_order always has a value between 0 and
> BITS_PER_LONG, GENMASK should be exactly what is wanted.

While GENMASK may do the job, the code is already quite obscure,
so I'm going to stick with the minimal delta to get this right,
namely

-               align_mask = 0xffffffffffffffffl >> (64 - align_order);
+               align_mask = ~0ul >> (BITS_PER_LONG - align_order);

--Sowmini

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/