Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbbGTTof (ORCPT ); Mon, 20 Jul 2015 15:44:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50466 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbGTTod (ORCPT ); Mon, 20 Jul 2015 15:44:33 -0400 Date: Mon, 20 Jul 2015 12:44:32 -0700 (PDT) Message-Id: <20150720.124432.1153242227929722638.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix fid_mask when leaving bridge From: David Miller In-Reply-To: <1436969227-30006-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1436969227-30006-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2015 12:44:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 28 From: Vivien Didelot Date: Wed, 15 Jul 2015 10:07:07 -0400 > The mv88e6xxx_priv_state structure contains an fid_mask, where 1 means > the FID is free to use, 0 means the FID is in use. > > This patch fixes the bit clear in mv88e6xxx_leave_bridge() when > assigning a new FID to a port. > > Example scenario: I have 7 ports, port 5 is CPU, port 6 is unused (no > PHY). After setting the ports 0, 1 and 2 in bridge br0, and ports 3 and > 4 in bridge br1, I have the following fid_mask: 0b111110010110 (0xf96). > > Indeed, br0 uses FID 0, and br1 uses FID 3. > > After setting nomaster for port 0, I get the wrong fid_mask: 0b10 (0x2). > > With this patch we correctly get 0b111110010100 (0xf94), meaning port 0 > uses FID 1, br0 uses FID 0, and br1 uses FID 3. > > Signed-off-by: Vivien Didelot Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/