Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756314AbbGTUCx (ORCPT ); Mon, 20 Jul 2015 16:02:53 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34194 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755078AbbGTUCv (ORCPT ); Mon, 20 Jul 2015 16:02:51 -0400 Date: Mon, 20 Jul 2015 22:02:49 +0200 From: Alexandre Belloni To: Peter Hurley Cc: Hans Ulli Kroll , Nicolas Ferre , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Cyrille Pitchen Subject: Re: [PATCH] tty/serial: atmel: use proper accessors Message-ID: <20150720200249.GK15539@piout.net> References: <1437400572-16575-1-git-send-email-alexandre.belloni@free-electrons.com> <55AD4683.3090708@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55AD4683.3090708@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1864 Lines: 51 Hi, (adding Hans in Cc) On 20/07/2015 at 15:05:39 -0400, Peter Hurley wrote : > Hi Alexandre, > > On 07/20/2015 09:56 AM, Alexandre Belloni wrote: > > On ARM, it is necessary to use the _relaxed versions of read[bl] and > > write[bl] to ensure we do the correct endianness conversion when running in > > big endian. > > Keep using avr32 __raw version on avr32 to avoid breakage. > > > > Signed-off-by: Alexandre Belloni > > --- > > > > This patch applies after [PATCH v4 0/5] tty/serial: at91: add support to FIFOs > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/353704.html > > > > drivers/tty/serial/atmel_serial.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > > index e91b3b2f0590..451acf054281 100644 > > --- a/drivers/tty/serial/atmel_serial.c > > +++ b/drivers/tty/serial/atmel_serial.c > > @@ -194,6 +194,7 @@ to_atmel_uart_port(struct uart_port *uart) > > return container_of(uart, struct atmel_uart_port, uart); > > } > > > > +#ifdef CONFIG_AVR32 > > The whole point of i/o accessors is to encapsulate arch-specific > differences, so one of these arches isn't doing it right, or the wrong > i/o accessors are being used. > I'm not an avr32 specialist but I think __raw accessors are doing big endian accesses but _relaxed accessors are doing litlle endian accesses. Maybe Hans can clarify what's needed here. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/