Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932085AbbGTUYh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jul 2015 16:24:37 -0400
Received: from mail-ig0-f182.google.com ([209.85.213.182]:36845 "EHLO
	mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752000AbbGTUYg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jul 2015 16:24:36 -0400
Message-ID: <55AD5902.7020209@kernel.dk>
Date: Mon, 20 Jul 2015 14:24:34 -0600
From: Jens Axboe <axboe@kernel.dk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Jeff Moyer <jmoyer@redhat.com>, Christoph Hellwig <hch@infradead.org>
CC: linux-kernel@vger.kernel.org, dmilburn@redhat.com
Subject: Re: [patch] Revert "block: remove artifical max_hw_sectors cap"
References: <x49bnf6y443.fsf@segfault.boston.devel.redhat.com>
In-Reply-To: <x49bnf6y443.fsf@segfault.boston.devel.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1253
Lines: 34

On 07/20/2015 01:17 PM, Jeff Moyer wrote:
>
> <resent with Jens' email address fixed>
>
> Hi,
>
> This reverts commit 34b48db66e08, which caused significant iozone
> performance regressions and uncovered a silent data corruption
> bug in at least one disk.
>
> For SAN storage, we've seen initial write and re-write performance drop
> 25-50% across all I/O sizes.  On locally attached storage, we've seen
> regressions of 40% for all I/O types, but only for I/O sizes larger than
> 1MB.

Do we have any understanding of where this regression is coming from? 
Even just basic info like iostats from a run would be useful.

> In addition to the performance issues, we've also seen data corruption
> on one disk/hba combination.  See
>    http://marc.info/?l=linux-ide&m=143680539400526&w=2

That's just sucky hardware... That said, it is indeed one of the risks. 
We had basically the same transition from 255 as max sectors, since we 
depended on ATA treating 0 == 256 sectors (as per spec).

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/