Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756743AbbGTV2i (ORCPT ); Mon, 20 Jul 2015 17:28:38 -0400 Received: from www.linutronix.de ([62.245.132.108]:57563 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbbGTV2g (ORCPT ); Mon, 20 Jul 2015 17:28:36 -0400 Date: Mon, 20 Jul 2015 23:28:17 +0200 (CEST) From: Thomas Gleixner To: Suravee Suthikulpanit cc: marc.zyngier@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, tomasz.nowicki@linaro.org, rjw@rjwysocki.net, al.stone@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, msalter@redhat.com, grant.likely@linaro.org, leo.duran@amd.com, sherry.hurwitz@amd.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFCv2 PATCH 1/8] irqdomain: Introduce irq_domain_ops.init_alloc_info In-Reply-To: <1436778864-17645-2-git-send-email-Suravee.Suthikulpanit@amd.com> Message-ID: References: <1436778864-17645-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1436778864-17645-2-git-send-email-Suravee.Suthikulpanit@amd.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 29 On Mon, 13 Jul 2015, Suravee Suthikulpanit wrote: > Currently, when calling irq_domain_alloc_irqs() on ARM64, it uses > struct of_phandle_args to pass irq information. However, this is not > appropriate for ACPI since of_phandle_args is specific to DT. > > Therefore, this patch introduces a new function pointer, > irq_domain_ops.init_alloc_info, which can be used by irqchips to provide > a way to initialize irqchip-specific data-structure for allocating IRQ. > > Signed-off-by: Suravee Suthikulpanit > --- > NOTE: > Similarly, x86 is currently using struct irq_alloc_info > (see arch/x86/include/asm/hw_irq.h) and each irq_domain has different > way of initializing this structure. And why don't you use the same mechanism on ARM and have a private irq_alloc_info implementation which can carry either DT or ACPI information? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/