Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756837AbbGTWSH (ORCPT ); Mon, 20 Jul 2015 18:18:07 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:60690 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752431AbbGTWSE (ORCPT ); Mon, 20 Jul 2015 18:18:04 -0400 Message-ID: <55AD73A3.6000706@wwwdotorg.org> Date: Mon, 20 Jul 2015 16:18:11 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrey Danin CC: devicetree@vger.kernel.org, devel@linuxdriverproject.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, ac100@lists.launchpad.net, Laxman Dewangan , Wolfram Sang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Thierry Reding , Alexandre Courbot , Greg Kroah-Hartman , Julian Andres Klode , Marc Dietrich Subject: Re: [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver References: <1437424546-30405-1-git-send-email-danindrey@mail.ru> <1437424546-30405-3-git-send-email-danindrey@mail.ru> In-Reply-To: <1437424546-30405-3-git-send-email-danindrey@mail.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 21 On 07/20/2015 02:35 PM, Andrey Danin wrote: > Remove i2c controller related code and use tegra i2c driver in slave mode. > Update nvec documentation. > diff --git a/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt b/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt I would expect this patch to add a new binding file nvidia,nvec-slave.txt so that the filename continues to match the compatible value it documents. This patch introduces a new binding for the NVEC slave as opposed to modifying the existing binding. > +- compatible : should be "nvidia,nvec-slave". > +- reg: the i2c address of the slave controller I think "the I2C address to respond to" would be clearer? You might also mention that this needs to include flags from . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/