Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbbGUDbB (ORCPT ); Mon, 20 Jul 2015 23:31:01 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31185 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbGUDbA (ORCPT ); Mon, 20 Jul 2015 23:31:00 -0400 From: Bob Liu To: xen-devel@lists.xenproject.org Cc: david.vrabel@citrix.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com, konrad.wilk@oracle.com, Bob Liu Subject: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free Date: Tue, 21 Jul 2015 11:30:40 +0800 Message-Id: <1437449441-2964-2-git-send-email-bob.liu@oracle.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1437449441-2964-1-git-send-email-bob.liu@oracle.com> References: <1437449441-2964-1-git-send-email-bob.liu@oracle.com> X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 29 This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info->indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index e266d17..c98fcd0 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -986,7 +986,6 @@ static void blkif_free(struct blkfront_info *info, int suspend) if (!list_empty(&info->indirect_pages)) { struct page *indirect_page, *n; - BUG_ON(info->feature_persistent); list_for_each_entry_safe(indirect_page, n, &info->indirect_pages, lru) { list_del(&indirect_page->lru); __free_page(indirect_page); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/