Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbGUF5t (ORCPT ); Tue, 21 Jul 2015 01:57:49 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:58919 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbbGUF5r convert rfc822-to-8bit (ORCPT ); Tue, 21 Jul 2015 01:57:47 -0400 Date: Tue, 21 Jul 2015 14:57:44 +0900 Message-ID: <87wpxunjc7.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Arnd Bergmann , OGAWA Hirofumi , Jens Axboe , "linux-next@vger.kernel.org" Subject: Re: Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time" In-Reply-To: <55AD5265.5070109@roeck-us.net> References: <55AD5265.5070109@roeck-us.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 39 On Tue, 21 Jul 2015 04:56:21 +0900, Guenter Roeck wrote: > > Hi, > > Commit 52b2512d507d ("asm-generic: {get,put}_user ptr argument evaluate only 1 time") > causes the following compile error with various architectures (arc, arcv2, c6x, hexagon, > um, unicore32) in -next. > > block/scsi_ioctl.c: In function ?sg_scsi_ioctl?: > block/scsi_ioctl.c:436:2: error: invalid initializer > if (get_user(opcode, sic->data)) > ^ > make[1]: *** [block/scsi_ioctl.o] Error 1 > > A possible fix would be to use &sic->data[0] instead, but I am not sure if this change > in semantics of get_user would be acceptable. > > Another failure due to the same commit is seen when building arc:axs103_defconfig. > > fs/fat/dir.c: In function ?fat_ioctl_filldir?: > fs/fat/dir.c:752:43: error: invalid initializer > FAT_IOCTL_FILLDIR_FUNC(fat_ioctl_filldir, __fat_dirent) > > This error is related to the put_user changes. No idea how to fix that one. > > Guenter Sorry. I misunderstand specification of get_user. I'll send fixed patch. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/