Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbbGUGRh (ORCPT ); Tue, 21 Jul 2015 02:17:37 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34901 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbbGUGRg (ORCPT ); Tue, 21 Jul 2015 02:17:36 -0400 Date: Tue, 21 Jul 2015 08:17:31 +0200 From: Ingo Molnar To: Paolo Pisati Cc: Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields Message-ID: <20150721061731.GA355@gmail.com> References: <1437411100-10357-1-git-send-email-p.pisati@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437411100-10357-1-git-send-email-p.pisati@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 39 * Paolo Pisati wrote: > hd0_info and hd1_info are not used anymore, don't reference them in the code > > Signed-off-by: Paolo Pisati > --- > arch/x86/kernel/kexec-bzimage64.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c > index 3666a84..c0ae428 100644 > --- a/arch/x86/kernel/kexec-bzimage64.c > +++ b/arch/x86/kernel/kexec-bzimage64.c > @@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params, > /* Default APM info */ > memset(¶ms->apm_bios_info, 0, sizeof(params->apm_bios_info)); > > - /* Default drive info */ > - memset(¶ms->hd0_info, 0, sizeof(params->hd0_info)); > - memset(¶ms->hd1_info, 0, sizeof(params->hd1_info)); > - > if (image->type == KEXEC_TYPE_CRASH) { > ret = crash_setup_memmap_entries(image, params); > if (ret) But they are not unused: we pass them to secondary kernel images, via kcrash for example. So it makes sense to zero out these parameters. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/