Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbbGUGbK (ORCPT ); Tue, 21 Jul 2015 02:31:10 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:33819 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbbGUGbI (ORCPT ); Tue, 21 Jul 2015 02:31:08 -0400 MIME-Version: 1.0 In-Reply-To: <20150721062858.GA5110@gmail.com> References: <1437354550-25858-1-git-send-email-brgerst@gmail.com> <1437354550-25858-5-git-send-email-brgerst@gmail.com> <20150721062858.GA5110@gmail.com> From: Andy Lutomirski Date: Mon, 20 Jul 2015 23:30:47 -0700 Message-ID: Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct To: Ingo Molnar Cc: Brian Gerst , X86 ML , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , Denys Vlasenko , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 24 On Mon, Jul 20, 2015 at 11:28 PM, Ingo Molnar wrote: > > * Brian Gerst wrote: > >> Allocate a separate structure for the vm86 fields. > > Why is this allocated dynamically? This structure is not very large, and a hole in > thread_struct isn't that big of an issue - compared to additional fragility > introduced by the (mostly untested by normal apps) dynamic allocation here ... > > I don't mind the introduction of the sub-structure in itself, but please embedd it > in thread_struct. > This ends up being several hundred bytes, I think, due to including an entire struct pt_regs. Do we really want to enlarge thread_struct that much for something that's essentially never used? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/