Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbbGUGc2 (ORCPT ); Tue, 21 Jul 2015 02:32:28 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:33630 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbGUGcY (ORCPT ); Tue, 21 Jul 2015 02:32:24 -0400 Date: Tue, 21 Jul 2015 08:31:55 +0200 From: Ingo Molnar To: Brian Gerst Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Denys Vlasenko , Andy Lutomirski , Linus Torvalds Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Message-ID: <20150721063155.GA7949@gmail.com> References: <1437354550-25858-1-git-send-email-brgerst@gmail.com> <1437354550-25858-5-git-send-email-brgerst@gmail.com> <20150721062858.GA5110@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150721062858.GA5110@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 24 * Ingo Molnar wrote: > * Brian Gerst wrote: > > > Allocate a separate structure for the vm86 fields. > > Why is this allocated dynamically? This structure is not very large, and a hole > in thread_struct isn't that big of an issue - compared to additional fragility > introduced by the (mostly untested by normal apps) dynamic allocation here ... > > I don't mind the introduction of the sub-structure in itself, but please embedd > it in thread_struct. Otherwise I have no objections to the rest of the series, nice fixes! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/