Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbbGUGyt (ORCPT ); Tue, 21 Jul 2015 02:54:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55950 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbbGUGyr convert rfc822-to-8bit (ORCPT ); Tue, 21 Jul 2015 02:54:47 -0400 From: "Sricharan" To: "'Ivan T. Ivanov'" Cc: , , , , , , , References: <1436412350-19519-1-git-send-email-sricharan@codeaurora.org> <1436412350-19519-3-git-send-email-sricharan@codeaurora.org> <1437380700.6267.1.camel@mm-sol.com> In-Reply-To: <1437380700.6267.1.camel@mm-sol.com> Subject: RE: [PATCH V4 2/7] qup: i2c: factor out common code for reuse Date: Tue, 21 Jul 2015 12:24:38 +0530 Message-ID: <000001d0c382$2061ceb0$61256c10$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 15.0 Thread-index: AQIhP+Z77323UyUNQOiucUIcbZiX1ACC7JHQARoJ24WdN5wIkA== Content-language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 54 Hi Ivan, Thnaks for all the reviews. > -----Original Message----- > From: linux-arm-msm-owner@vger.kernel.org [mailto:linux-arm-msm- > owner@vger.kernel.org] On Behalf Of Ivan T. Ivanov > Sent: Monday, July 20, 2015 1:55 PM > To: Sricharan R > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; > galak@codeaurora.org; linux-kernel@vger.kernel.org; linux- > i2c@vger.kernel.org; agross@codeaurora.org; dmaengine@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH V4 2/7] qup: i2c: factor out common code for reuse > > > Hi Sricharan, > > On Thu, 2015-07-09 at 08:55 +0530, Sricharan R wrote: > > > > > static int qup_i2c_read_one(struct qup_i2c_dev *qup, struct i2c_msg > > *msg) { > > - unsigned long left; > > - int ret; > > + int ret = 0; > > > > - qup->msg = msg; > > - qup->pos = 0; > > + /* > > + * The QUP block will issue a NACK and STOP on the bus when > reaching > > + * the end of the read, the length of the read is specified as one > byte > > + * which limits the possible read to 256 (QUP_READ_LIMIT) bytes. > > + */ > > + if (msg->len > QUP_READ_LIMIT) { > > + dev_err(qup->dev, "HW not capable of reads over %d bytes\n", > > + QUP_READ_LIMIT); > > + return -EINVAL; > > + } > > > > This should be removed. Please see qup_i2c_quirks. > Ok get it, will remove this. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/