Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbbGUHfB (ORCPT ); Tue, 21 Jul 2015 03:35:01 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:36314 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807AbbGUHe7 (ORCPT ); Tue, 21 Jul 2015 03:34:59 -0400 Date: Tue, 21 Jul 2015 09:37:39 +0200 From: Daniel Vetter To: Sudip Mukherjee Cc: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: remove unnecessary null test Message-ID: <20150721073739.GV16722@phenom.ffwll.local> Mail-Followup-To: Sudip Mukherjee , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1437404761-2617-1-git-send-email-sudipm.mukherjee@gmail.com> <20150720153350.GK16722@phenom.ffwll.local> <20150721064118.GE5598@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150721064118.GE5598@sudip-PC> X-Operating-System: Linux phenom 4.2.0-rc1+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 40 On Tue, Jul 21, 2015 at 12:11:18PM +0530, Sudip Mukherjee wrote: > On Mon, Jul 20, 2015 at 05:33:50PM +0200, Daniel Vetter wrote: > > On Mon, Jul 20, 2015 at 08:36:01PM +0530, Sudip Mukherjee wrote: > > > While creating the debugfs file we are setting the inode->i_private to > > > dev. That same dev is passed to these functions as private of struct > > > seq_file via single_open(). So at this point it can never be NULL. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > > > > v1 was drm/i915: fix possible null pointer dereference > > > > There's still one left in i915_displayport_test_active_write. > I left it out intentionally as it was not used via single_open(). Will > include that and send v3. Well I didn't even read that far ;-) But ->write can only be called once you opened the file, which means it will be set up already correctly too. -Daniel > >Also please mention the commit that introduced these and Cc: the author. > > Also please Cc: Chris since he's commented on v1 of this patch. > sure, Chris was Cc: in v2 and will Cc: him in v3 also. > > regards > sudip > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/