Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbbGUHsx (ORCPT ); Tue, 21 Jul 2015 03:48:53 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35576 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbGUHsw (ORCPT ); Tue, 21 Jul 2015 03:48:52 -0400 Date: Tue, 21 Jul 2015 09:48:47 +0200 From: Ingo Molnar To: Masami Hiramatsu Cc: Pratyush Anand , Ananth N Mavinakayanahalli , Rusty Russell , Linux Kernel Mailing List , Ingo Molnar , Rob Landley , "H. Peter Anvin" , Thomas Gleixner , "David S. Miller" Subject: Re: [PATCH tip/master 1/3] kprobes: Support blacklist functions in module Message-ID: <20150721074847.GA25542@gmail.com> References: <20150716071053.14218.82072.stgit@localhost.localdomain> <20150716071055.14218.64129.stgit@localhost.localdomain> <20150717121037.GA9437@gmail.com> <55AB166B.9040509@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55AB166B.9040509@hitachi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 28 * Masami Hiramatsu wrote: > For some symbols we can do that. But it can conflict with other __section > attributes e.g. __sched, since a function must be placed in only one > section. [...] The the scheduler is not modular, so __sched should not be a problem in itself. > [...] So, IMHO, using section for expressing its attribute is not a good idea, > but I couldn't find another option in common function attribute. > > https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes > > Thus I've introduced NOKPROBE_SYMBOL macro which stores the target function > addresses (not the function itself) in the _kprobe_blacklist section. So the question is, in which cases do modules need this? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/