From: Marc Dietrich <marvin24@gmx.de>
To: Andrey Danin <danindrey@mail.ru>
Cc: Stephen Warren <swarren@wwwdotorg.org>, devicetree@vger.kernel.org,
        devel@linuxdriverproject.org, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, ac100@lists.launchpad.net,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Wolfram Sang <wsa@the-dreams.de>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Thierry Reding <thierry.reding@gmail.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Julian Andres Klode <jak@jak-linux.org>
Subject: Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
Date: Tue, 21 Jul 2015 10:25:31 +0200
Message-ID: <4778199.vGjAP5lpOS@fb07-iapwap2>
User-Agent: KMail/4.14.10 (Linux/4.1.2-marc; KDE/4.14.10; x86_64; ; )
In-Reply-To: <55ADE829.4030108@mail.ru>
References: <1437424546-30405-1-git-send-email-danindrey@mail.ru> <55AD73F4.2050502@wwwdotorg.org> <55ADE829.4030108@mail.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2571602.0YnnqBGjHM"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2181
Lines: 57

--nextPart2571602.0YnnqBGjHM
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="windows-1252"

Am Dienstag, 21. Juli 2015, 09:35:21 schrieb Andrey Danin:
> On 21.07.2015 1:19, Stephen Warren wrote:
> > On 07/20/2015 02:35 PM, Andrey Danin wrote:
> >> NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
> >> for NVEC node.
> >> 
> >> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> >> b/arch/arm/boot/dts/tegra20-paz00.dts
> >> 
> >> +        nvec: nvec@45 {
> >> +            compatible = "nvidia,nvec-slave";
> >> +            reg = <0x45>;
> > 
> > I think you need to or in I2C_OWN_SLAVE_ADDRESS from
> > <dt-bindings/i2c/i2c.h> here?
> 
> Sorry, I mentioned it in letter 0 only.
> I will rework nvec driver and device tree according to i2c core slave
> implementation later. v3 of this patchset is for fixing tegra i2c driver
> only.

I think in this case it would be better to leave nvec and dt as it is for now, 
and just add the slave function to tegra-i2c. Otherwise we will again have two 
different "nvidia,nvec-slave" bindings (one for the intermediate hack and one 
for the final representation). As an alternative, you could also add slave 
function and port nvec in the same series.

Marc

--nextPart2571602.0YnnqBGjHM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJVrgH7AAoJEKyeR39HFBtoUNAH/3uXLYSyTg+rWF+hEN+1A0e+
h/SL1QtahmapHS+mq7caG+F9irKll3jcMG2hJRbHTJLaxYJM0dpNJ9h9WrioOI5Z
+tHwmCpJpkgBmVf9728ON6vwpt2mAXnOgs1Gmg1ORxO0e8fBsC3lOlhbHmp/W+Z4
GJbWkKy376Poh2GvRxKidlJKyLURWWow1RWlj9HAQfNJVdqkK+dv8bxPEV7Cll4F
Rf/TBlM+djEdIf7vCTXlid+8wqHYygj1nPa68KmqpsQo2+ISEZ6++316xDFHD6pc
SG/9xY/o2zAmob9JC8GgNYWysM5+xUM3vUiK7OoVS37s5EnibQFkaKa7s3EEI4Y=
=J41g
-----END PGP SIGNATURE-----

--nextPart2571602.0YnnqBGjHM--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/