Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754126AbbGUJdP (ORCPT ); Tue, 21 Jul 2015 05:33:15 -0400 Received: from esgaroth.petrovitsch.at ([78.47.184.11]:5908 "EHLO esgaroth.tuxoid.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbbGUJdK (ORCPT ); Tue, 21 Jul 2015 05:33:10 -0400 X-Greylist: delayed 2939 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jul 2015 05:33:09 EDT Subject: Re: [PATCH v7 2/4] x86/stackvalidate: Compile-time stack validation From: Bernd Petrovitsch To: Josh Poimboeuf Cc: Namhyung Kim , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , Pedro Alves , x86@kernel.org, live-patching@vger.kernel.org, LKML Date: Tue, 21 Jul 2015 10:42:32 +0200 In-Reply-To: <20150720175026.GC28075@treble.redhat.com> References: <20150720175026.GC28075@treble.redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 (3.0.3-1.fc15) Content-Transfer-Encoding: 7bit Message-ID: <1437468154.32331.29.camel@thorin> Mime-Version: 1.0 X-DCC-debian-Metrics: esgaroth.tuxoid.at 1169; Body=15 Fuz1=15 Fuz2=15 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 AWL AWL: Adjusted score from AWL reputation of From: address Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 25 On Mon, 2015-07-20 at 12:50 -0500, Josh Poimboeuf wrote: [...] > It's perhaps distasteful, but it improves performance. And I'm a > pragmatist at heart ;-) And you measured the time gain guaranteeing that it actually saves that much time. Usually that isn't actually measurable .... And the usual solution is to have a preprocessor symbol to allow people with lots of time and/or "valgrind" and similar tools to clean up cleanly and the speed gang can compile that code out. Kind regards, Bernd -- "I dislike type abstraction if it has no real reason. And saving on typing is not a good reason - if your typing speed is the main issue when you're coding, you're doing something seriously wrong." - Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/