Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbbGUJZ4 (ORCPT ); Tue, 21 Jul 2015 05:25:56 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:42203 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbbGUJZy (ORCPT ); Tue, 21 Jul 2015 05:25:54 -0400 X-IronPort-AV: E=Sophos;i="5.15,515,1432598400"; d="scan'208";a="285996779" Message-ID: <55AE1019.6080906@citrix.com> Date: Tue, 21 Jul 2015 11:25:45 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu , CC: , , Subject: Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free References: <1437449441-2964-1-git-send-email-bob.liu@oracle.com> <1437449441-2964-2-git-send-email-bob.liu@oracle.com> In-Reply-To: <1437449441-2964-2-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 19 El 21/07/15 a les 5.30, Bob Liu ha escrit: > This BUG_ON() in blkif_free() is incorrect, because indirect page can be added > to list info->indirect_pages in blkif_completion() no matter feature_persistent > is true or false. > > Signed-off-by: Bob Liu Acked-by: Roger Pau Monn? This was probably an oversight from when blkif_completion was changed to check for gnttab_query_foreign_access. It should be backported to stable trees. Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/