Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755970AbbGUJuO (ORCPT ); Tue, 21 Jul 2015 05:50:14 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59795 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbbGUJuK (ORCPT ); Tue, 21 Jul 2015 05:50:10 -0400 Date: Tue, 21 Jul 2015 11:50:05 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, stsp@users.sourceforge.net, Andrew Lunn , Sakari Ailus Subject: Re: [PATCH/RFC 01/51] leds: Add led_set_brightness_sync to the public LED subsystem API Message-ID: <20150721095005.GB23841@amd> References: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> <1437122857-6765-2-git-send-email-j.anaszewski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437122857-6765-2-git-send-email-j.anaszewski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 49 On Fri 2015-07-17 10:46:47, Jacek Anaszewski wrote: > led_set_brightness_sync function was visible only internally to the > LED subsystem. It is now being made publicly available since it has > become apparent that this is a caller who should decide whether > brightness is to be set in a synchronous or an asynchronous way. > The function is modified to use brightness_set op as the second > option if brightness_set_sync is not implemented. Eventually all > LED subsystem drivers will be modfified to set brightness only in > a synchronous way with use of brightness_set op and brightness_set_sync > op will be removed. LED core will take care of calling brightness_set > op asynchronously if needed. As I explained before, having single brightness_set callback sometimes block and sometimes not based on flag elsewhere is a bad design. > Signed-off-by: Jacek Anaszewski > Cc: Bryan Wu > Cc: Andrew Lunn > Cc: Sakari Ailus Nacked-by: Pavel Machek > --- > drivers/leds/leds.h | 13 ------------- > include/linux/leds.h | 29 +++++++++++++++++++++++++++++ > 2 files changed, 29 insertions(+), 13 deletions(-) > > diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h > index bc89d7a..1c026c9 100644 > --- a/drivers/leds/leds.h > +++ b/drivers/leds/leds.h > @@ -26,19 +26,6 @@ static inline void led_set_brightness_async(struct led_classdev *led_cdev, > led_cdev->brightness_set(led_cdev, value); > } > > -static inline int led_set_brightness_sync(struct led_classdev *led_cdev, > - enum led_brightness value) > -{ > - int ret = 0; > - -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/