Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754321AbbGUJy6 (ORCPT ); Tue, 21 Jul 2015 05:54:58 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:51102 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbbGUJy5 (ORCPT ); Tue, 21 Jul 2015 05:54:57 -0400 X-IronPort-AV: E=Sophos;i="5.15,515,1432598400"; d="scan'208";a="286001901" Message-ID: <55AE16EC.2020204@citrix.com> Date: Tue, 21 Jul 2015 11:54:52 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , CC: , , , , "Konrad Rzeszutek Wilk" , Boris Ostrovsky , David Vrabel Subject: Re: [PATCH v2 05/20] block/xen-blkfront: Split blkif_queue_request in 2 References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-6-git-send-email-julien.grall@citrix.com> In-Reply-To: <1436474552-31789-6-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1796 Lines: 56 El 09/07/15 a les 22.42, Julien Grall ha escrit: > Currently, blkif_queue_request has 2 distinct execution path: > - Send a discard request > - Send a read/write request > > The function is also allocating grants to use for generating the > request. Although, this is only used for read/write request. > > Rather than having a function with 2 distinct execution path, separate > the function in 2. This will also remove one level of tabulation. > > Signed-off-by: Julien Grall > Cc: Konrad Rzeszutek Wilk > Cc: Roger Pau Monné > Cc: Boris Ostrovsky > Cc: David Vrabel Patch looks fine, although with so much indentation changes it's kind of hard to review. Acked-by: Roger Pau Monné Just one minor change below. [...] > @@ -595,6 +603,24 @@ static int blkif_queue_request(struct request *req) > return 0; > } > > +/* > + * Generate a Xen blkfront IO request from a blk layer request. Reads > + * and writes are handled as expected. > + * > + * @req: a request struct > + */ > +static int blkif_queue_request(struct request *req) > +{ > + struct blkfront_info *info = req->rq_disk->private_data; > + > + if (unlikely(info->connected != BLKIF_STATE_CONNECTED)) > + return 1; > + > + if (unlikely(req->cmd_flags & (REQ_DISCARD | REQ_SECURE))) > + return blkif_queue_discard_req(req); > + else > + return blkif_queue_rw_req(req); There's no need for the else clause. Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/